SUBMARINE-1290. Add k8s labels to k8s resources in submarine-cloud-v3
What is this PR for?
Add app.kubernetes.io labels recommended here by Kubernetes https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
What type of PR is it?
Improvement
Todos
- [x] - Add app.kubernetes.io labels in submarine-cloud-v3 artifacts
What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1290
How should this be tested?
Follow the submarine-cloud-v3/docs/developer-guide.md
Screenshots (if appropriate)
Questions:
- Do the license files need updating? No
- Are there breaking changes for older versions? No
- Does this need new documentation? No
Hi~ Thanks for your contribution.
Can we replace app.kubernetes.io/version value using a consistent method? I personally don't think hard-coding the version is a good way.
Another question is whether we have any way to test the current updates?
@cdmikechen thanks for your feedback! I will update my changes soon and push again.
Codecov Report
Merging #976 (fcfd6a6) into master (e7ed4a5) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #976 +/- ##
========================================
Coverage 9.18% 9.18%
Complexity 670 670
========================================
Files 234 234
Lines 23716 23716
Branches 3475 3475
========================================
Hits 2178 2178
Misses 21407 21407
Partials 131 131
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more