submarine-workbench-v2 - Frontend

[litmus-zhang]

What is this PR for?

What type of PR is it?

[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring] Improvement

Todos

• [
• Created the components of the experiment page
• ] - Task

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

• Do the license files need updating? Yes/No
• Are there breaking changes for older versions? Yes/No
• Does this need new documentation? Yes/No No

[codecov[bot]]

Codecov Report

Merging #967 (491b6e2) into master (2a994f1) will decrease coverage by 15.23%. The diff coverage is n/a.

@@              Coverage Diff              @@
##             master     #967       +/-   ##
=============================================
- Coverage     26.65%   11.41%   -15.24%     
- Complexity       53      814      +761     
=============================================
  Files            34      250      +216     
  Lines           709    24860    +24151     
  Branches         57     3561     +3504     
=============================================
+ Hits            189     2839     +2650     
- Misses          498    21844    +21346     
- Partials         22      177      +155     

Impacted Files	Coverage Δ
...se/workbench/utils/CustomJsonDateDeserializer.java	0.00% <0.00%> (ø)
.../apache/submarine/server/api/workbench/Action.java	0.00% <0.00%> (ø)
...rg/apache/submarine/server/api/workbench/Role.java	0.00% <0.00%> (ø)
...marine/server/utils/gson/NotebookIdSerializer.java	50.00% <0.00%> (ø)
...database/workbench/entity/SysDeptSelectEntity.java	36.36% <0.00%> (ø)
...e/server/submitter/k8s/model/common/Configmap.java	0.00% <0.00%> (ø)
...pache/submarine/commons/cluster/ClusterServer.java	57.82% <0.00%> (ø)
...e/submarine/serve/seldon/SeldonDeploymentList.java	0.00% <0.00%> (ø)
...er/database/workbench/entity/TeamMemberEntity.java	0.00% <0.00%> (ø)
.../submarine/server/manager/ModelVersionManager.java	45.56% <0.00%> (ø)
... and 206 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a994f1...491b6e2. Read the comment docs.

[litmus-zhang]

Oh I was worried about the license, I will fix that today

On Sat, Jun 25, 2022, 14:26 kuanhsun @.***> wrote:

@.**** requested changes on this pull request.

@litmus-zhang https://github.com/litmus-zhang Here are some requests, thanks.

1. All of the files required a Licence comment on the top.
2. Also, fix the test. Others, LGTM.

— Reply to this email directly, view it on GitHub https://github.com/apache/submarine/pull/967#pullrequestreview-1019308328, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJUY2ZD2CKAHUAWYUIIM2BDVQ4CHNANCNFSM5Y7DI2FQ . You are receiving this because you were mentioned.Message ID: @.***>