storm icon indicating copy to clipboard operation
storm copied to clipboard

[STORM-3680] Upgrade Jedis Library

Open Crim opened this issue 5 years ago • 1 comments

What is the purpose of the change

To support future improvements to the storm-redis package, lets upgrade its underlying library (Jedis) it uses to communicate with Redis.

Upgrading will clear the way for STORM-3665 as Stream support in the Jedis library was not added until version 3.x

How was the change tested / Note Question

As no previous test coverage existed for the bolts provided by storm-redis I've started to add integration tests using TestContainers which depends on Docker being available and running to provide Redis instances. Let me know if this is an acceptable way to provide test coverage and I will build out tests for the remaining bolts.

Crim avatar Jul 26 '20 02:07 Crim

@HeartSaVioR since it looks like you were the last to make any significant changes to this module, do you mind taking a look and letting me your thoughts on this, as well if using TestContainers is an appropriate way to add test coverage for this?

Thanks!

Crim avatar Aug 27 '20 06:08 Crim

oh snap, is this finally get a review?

Crim avatar Dec 04 '23 09:12 Crim