spark icon indicating copy to clipboard operation
spark copied to clipboard

[SPARK-49992][SQL] Session level collation should not impact DDL queries

Open stefankandic opened this issue 1 year ago • 1 comments

What changes were proposed in this pull request?

This PR proposes not using session-level collation in DDL commands, specifically in CREATE TABLE v2 and ALTER TABLE ADD/REPLACE COLUMNS commands.

Why are the changes needed?

The default collation for DDL commands should be tied to the object being created or altered (e.g., table, view, schema) rather than the session-level setting. Since object-level collations are not yet supported, we will assume the UTF8_BINARY collation by default for now.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Added new unit tests.

Was this patch authored or co-authored using generative AI tooling?

No.

stefankandic avatar Oct 12 '24 21:10 stefankandic

Please take a look when you have the time @mihailom-db @cloud-fan

stefankandic avatar Oct 16 '24 12:10 stefankandic

@cloud-fan can you take a look again as this PR is blocking some future changes that are needed?

stefankandic avatar Oct 22 '24 14:10 stefankandic

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

github-actions[bot] avatar Feb 22 '25 00:02 github-actions[bot]