solr
solr copied to clipboard
SOLR-17467: Fix Windows start script on 9x and optimize deprecation messages
https://issues.apache.org/jira/browse/SOLR-17467
Description
The Windows start script on 9x behaves differently than on main / 10.0, and fails with the message "mode. was unexpected at this time.". This mesage is coming from the deprecation warnings.
Solution
The fix moves the deprecation warnings to the dedicated mode setter functions and uses echo instead of @echo, which probably caused the execution error.
Additionally, this commit adds support for the --user-managed mode that allows the user to suppress the deprecation warning by being explicit about the current mode.
Tests
Not tests were altered.
Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [X] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [ ] I have developed this patch against the
mainbranch. - [X] I have run
./gradlew check. - [ ] I have added tests for my changes.
- [ ] I have added documentation for the Reference Guide