solr icon indicating copy to clipboard operation
solr copied to clipboard

SOLR-16466 - Admin UI - Make it optional to sort list of commandline …

Open freedev opened this issue 1 year ago • 0 comments

…args

https://issues.apache.org/jira/browse/SOLR-16466

Description

Added a call to action (checkbox) at end of JVM Command-Line Arguments. The arguments are unsorted (original order) by default , when the checkbox is selected the arguments are sorted lexicographically.

Solution

Added a checkbox in the dashboard at end of JVM Command-Line Arguments. Changed Angular IndexController (the component behind the Admin Dashboard):

  • changed reload function: save a copy of the original commandline args and check the order
  • Added toggleCommandLineOrder function - handle the checkbox click
  • Added showCommandLineArgs function - show the args list with the correct order

Tests

I have tested the changes locally running solr standalone

Checklist

Please review the following and check all that apply:

  • [X] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • [ ] I have created a Jira issue and added the issue ID to my pull request title.
  • [X] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • [X] I have developed this patch against the main branch.
  • [X] I have run ./gradlew check.
  • [ ] I have added tests for my changes.
  • [ ] I have added documentation for the Reference Guide

freedev avatar Feb 06 '24 14:02 freedev