skywalking icon indicating copy to clipboard operation
skywalking copied to clipboard

[INFRA-E2E][Bug] E2E mismatch actual data still pass the expected template

Open kezhenxu94 opened this issue 3 years ago • 3 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component

Infra E2E (apache/skywalking-infra-e2e)

What happened

https://github.com/apache/skywalking/blob/547f1ede2d1665601cb9d9a3853ed205620d6c83/test/e2e-v2/cases/lua/expected/service-instance-nginx.yml#L23-L36

These kind of data should not appear in a Lua agent but the tests still passed

What you expected to happen

Current E2E tests of Lua, Python (and maybe others) should fail.

How to reproduce

Run the E2E tests in the current master branch, tests are passed, but should be failed

Anything else

No response

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

kezhenxu94 avatar Mar 26 '22 02:03 kezhenxu94

The first entry is not evaluated at all, the entire index or additional index can be removed/ added still passing test, but a mixed order list of actual data will lead to error.

Put the following at top of contains will make sure the true first entry should be checked.

- e2eplaceholder: workaround-placeholder-for-e2e
    placeholder: ISHOULDNOTEXIST

Superskyyy avatar Mar 30 '22 03:03 Superskyyy

I am interested in this issue, please assign this to me~

Chever-John avatar May 12 '22 01:05 Chever-John

@Chever-John assign to you, welcome~~

mrproliu avatar May 12 '22 01:05 mrproliu