skywalking icon indicating copy to clipboard operation
skywalking copied to clipboard

[INFRA/eyes] Support for Ruby/Rails files

Open afriqs opened this issue 4 years ago • 2 comments

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Description

License headers for ruby (.rb) ans rails (.erb) files are not supported yet due to lack of comment_style_id.

Use case

Add license headers to such files.

Related issues

No response

Are you willing to submit a PR?

  • [X] Yes I am willing to submit a PR!

Code of Conduct

afriqs avatar Sep 17 '21 14:09 afriqs

Hi,

I would like to provide tests but I don't see how :shrug:

When I cd test && go test -v I only see two passing tests : TestConfigHeaderSpdxASF and TestConfigHeaderSpdxPlain.

I think it may be related to test/tesdata/include_test/with[out]_license but don't know how ti use them...

Note : not a go developer :innocent:

afriqs avatar Sep 20 '21 14:09 afriqs

Hi @afriqs , thank you. The tests directory serves as a demonstration data actually. And for new file support, you might want to add a case in https://github.com/apache/skywalking-eyes/blob/main/pkg/header/fix_test.go

kezhenxu94 avatar Sep 20 '21 15:09 kezhenxu94

No update for 1 year, closing

kezhenxu94 avatar Sep 17 '22 05:09 kezhenxu94