skywalking icon indicating copy to clipboard operation
skywalking copied to clipboard

[Feature] Add URLParser for Derby/Sybase/SQLite/DB2/OceanBase

Open CzyerChen opened this issue 1 year ago • 1 comments

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Description

current DB types in URLParser :

  • MYSQL
  • ORACLE
  • H2
  • POSTGRESQL
  • MARIADB
  • MSSQL
  • KYLIN
  • IMPALA
  • CLICKHOUSE

I want to add URL parsing types:

  • Derby
  • Sybase
  • SQLite
  • DB2
  • OceanBase

Use case

When the database connection pool connecting to Derby/Sybase/SQLite/DB2/OceanBase, JDBC URL can be parsed and the monitoring meters can be reported.

Related issues

No response

Are you willing to submit a pull request to implement this on your own?

  • [X] Yes I am willing to submit a pull request on my own!

Code of Conduct

CzyerChen avatar May 10 '24 10:05 CzyerChen

Can we make sure the only gap for tracing these databases JDBC access are about this? Because AFAIK, if we don't add instrument for driver explicitly, the connection info is still missing.

wu-sheng avatar May 10 '24 10:05 wu-sheng

Can we make sure the only gap for tracing these databases JDBC access are about this? Because AFAIK, if we don't add instrument for driver explicitly, the connection info is still missing.

None of these databases have plugins to track SQL statements now, and adding these URLParsers can make connection pools report pool metrics of these databases successfully. image

Meanwhile, for database connection pools like druid/c3p0, it is necessary to optimized the part on obtaining ConnectionInfo of the database that have not yet implemented monitoring to avoid NPE.

CzyerChen avatar May 11 '24 00:05 CzyerChen

None of these databases have plugins to track SQL statements now, and adding these URLParsers can make connection pools report pool metrics of these databases successfully.

So, this is for meter plugin enhancement. Please update docs here as well, https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/supported-list/#meter-plugins, to list all supported database.

wu-sheng avatar May 11 '24 00:05 wu-sheng

https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/supported-list/#meter-plugins

OK.

CzyerChen avatar May 11 '24 01:05 CzyerChen