skywalking-java icon indicating copy to clipboard operation
skywalking-java copied to clipboard

Add the JDK 25 support

Open peachisai opened this issue 1 month ago • 4 comments

  • [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number.
  • [x] Update the CHANGES log.

peachisai avatar Dec 09 '25 15:12 peachisai

apache/skywalking#13454

This is not related to the issue. The JVM25 adoption is about OAP side.

wu-sheng avatar Dec 09 '25 16:12 wu-sheng

Compiling passed. We at least need one plugin test to verify the plugin works on JVM25, e.g. a spring case.

wu-sheng avatar Dec 10 '25 01:12 wu-sheng

something wrong, let me check

peachisai avatar Dec 10 '25 04:12 peachisai

https://github.com/docker-library/tomcat/issues/334 Tomcat community stopped including curl in the JDK 22+ images, so the test step fails because the curl command is not available. I have added a new Dockerfile to build an image based on the tomcat-jdk25 image with curl installed.

peachisai avatar Dec 12 '25 14:12 peachisai

The tests are till failing. Could you recheck?

wu-sheng avatar Dec 13 '25 06:12 wu-sheng

The tests are till failing. Could you recheck? image

Hi, I tested this in my local environment. Could you please retrigger the tests? I found that the failed tests are different each time.

peachisai avatar Dec 13 '25 06:12 peachisai

The tests are till failing. Could you recheck? image

Just now I had re-triggered all tests in my local env, all of them have passed. Maybe we still need to retrigger one or more times.

peachisai avatar Dec 13 '25 07:12 peachisai

@wu-sheng Hi, could have a review?

peachisai avatar Dec 14 '25 13:12 peachisai

Yes, tests passed. I left one comment about how to setup JDK 25 case locally, please update the document or script to make developers convenient locally.

wu-sheng avatar Dec 14 '25 14:12 wu-sheng

have added a new Dockerfile to build an image based on the tomcat-jdk25 image with curl installed.

Updated

peachisai avatar Dec 14 '25 14:12 peachisai