skywalking-java icon indicating copy to clipboard operation
skywalking-java copied to clipboard

fix CVE-2024-7254

Open alanlvle opened this issue 1 year ago • 12 comments

  • [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • [ ] Update the CHANGES log.

alanlvle avatar Oct 10 '24 16:10 alanlvle

I think somehow the compiling is broken by this. Could you try compiling locally and fix?

wu-sheng avatar Oct 10 '24 23:10 wu-sheng

Maybe, you don't bump up protobuf-maven-plugin.version accordingly. They should be aligned.

wu-sheng avatar Oct 10 '24 23:10 wu-sheng

I try do it

alanlvle avatar Oct 11 '24 01:10 alanlvle

protobuf-maven-plugin.version is old.how to get new protobuf-maven-plugin version aligned to protobuf-java

alanlvle avatar Oct 11 '24 03:10 alanlvle

protobuf-java should have documents mentioned that.

wu-sheng avatar Oct 11 '24 03:10 wu-sheng

I suppose grpc-java version should be compatible with the upgraded protobuf-java

lujiajing1126 avatar Oct 11 '24 03:10 lujiajing1126

com.google.protobuf:protobuf-java is only used in java-agent-network,so,only update com.google.protobuf:protobuf-java in java-agent-network

alanlvle avatar Oct 11 '24 07:10 alanlvle

Why don't update the gRPC accordingly? I think taking the risk of incompatible grpc and protobuf version are not a good idea.

wu-sheng avatar Oct 11 '24 13:10 wu-sheng

io.grpc:grpc-protobuf last version 1.68.0 not fix CVE-2024-7254.so,only update com.google.protobuf:protobuf-java to 3.25.5

alanlvle avatar Oct 11 '24 13:10 alanlvle

I think we can wait. We don't have plans to release the next Java agent soon. Not much changed.

image

wu-sheng avatar Oct 11 '24 13:10 wu-sheng

OK

alanlvle avatar Oct 11 '24 14:10 alanlvle

io.grpc:grpc-protobuf last version 1.68.0 not fix CVE-2024-7254.so,only update com.google.protobuf:protobuf-java to 3.25.5

https://repo1.maven.org/maven2/io/grpc/grpc-protobuf/1.68.0/grpc-protobuf-1.68.0.pom

grpc-protobuf 1.68.0 already uses protobuf-java 3.25.3. I think patch version bump will not break the compatibility.

See the comment here https://github.com/grpc/grpc-java/issues/11542#issuecomment-2364573148

Also, the upstream PR https://github.com/grpc/grpc-java/pull/11543 shows nothing change except version number.

lujiajing1126 avatar Oct 11 '24 15:10 lujiajing1126

No update. Please reopen when you are ready.

wu-sheng avatar Oct 31 '24 07:10 wu-sheng