fix CVE-2024-7254
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #
. - [ ] Update the
CHANGESlog.
I think somehow the compiling is broken by this. Could you try compiling locally and fix?
Maybe, you don't bump up protobuf-maven-plugin.version accordingly. They should be aligned.
I try do it
protobuf-maven-plugin.version is old.how to get new protobuf-maven-plugin version aligned to protobuf-java
protobuf-java should have documents mentioned that.
I suppose grpc-java version should be compatible with the upgraded protobuf-java
com.google.protobuf:protobuf-java is only used in java-agent-network,so,only update com.google.protobuf:protobuf-java in java-agent-network
Why don't update the gRPC accordingly? I think taking the risk of incompatible grpc and protobuf version are not a good idea.
io.grpc:grpc-protobuf last version 1.68.0 not fix CVE-2024-7254.so,only update com.google.protobuf:protobuf-java to 3.25.5
I think we can wait. We don't have plans to release the next Java agent soon. Not much changed.
OK
io.grpc:grpc-protobuf last version 1.68.0 not fix CVE-2024-7254.so,only update com.google.protobuf:protobuf-java to 3.25.5
https://repo1.maven.org/maven2/io/grpc/grpc-protobuf/1.68.0/grpc-protobuf-1.68.0.pom
grpc-protobuf 1.68.0 already uses protobuf-java 3.25.3. I think patch version bump will not break the compatibility.
See the comment here https://github.com/grpc/grpc-java/issues/11542#issuecomment-2364573148
Also, the upstream PR https://github.com/grpc/grpc-java/pull/11543 shows nothing change except version number.
No update. Please reopen when you are ready.