shenyu icon indicating copy to clipboard operation
shenyu copied to clipboard

[type:fix][ISSUE #5332] Fix restart plugin.

Open YxYL6125 opened this issue 2 years ago • 4 comments

Fixes https://github.com/apache/shenyu/issues/5332 & https://github.com/apache/shenyu/issues/5292

changes:

  • add remove cache logic when closing plugin in class AbstractLogPluginDataHandler.

Make sure that:

  • [x] You have read the contribution guidelines.
  • [x] You submit test cases (unit or integration tests) that back your changes.
  • [x] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

YxYL6125 avatar Dec 02 '23 07:12 YxYL6125

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2f017d3) 61.84% compared to head (c6b64d9) 61.75%. Report is 1 commits behind head on master.

Files Patch % Lines
...java/org/apache/shenyu/common/utils/Singleton.java 0.00% 2 Missing :warning:
...g/common/handler/AbstractLogPluginDataHandler.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5337      +/-   ##
============================================
- Coverage     61.84%   61.75%   -0.09%     
+ Complexity     8689     8680       -9     
============================================
  Files          1255     1255              
  Lines         38348    38350       +2     
  Branches       3673     3670       -3     
============================================
- Hits          23717    23684      -33     
- Misses        12518    12542      +24     
- Partials       2113     2124      +11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 02 '23 07:12 codecov-commenter

not right

moremind avatar Dec 02 '23 12:12 moremind

#5332 because ext plugin has been removed from plugins cache

moremind avatar Dec 02 '23 12:12 moremind

#5332 because ext plugin has been removed from plugins cache

It is, my negligence :sweat_drops:

YxYL6125 avatar Dec 02 '23 13:12 YxYL6125