shenyu icon indicating copy to clipboard operation
shenyu copied to clipboard

[type:feat] use binary search optimize random load balance

Open eye-gu opened this issue 2 years ago • 4 comments

close #4932

Make sure that:

  • [x] You have read the contribution guidelines.
  • [ ] You submit test cases (unit or integration tests) that back your changes.
  • [x] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

eye-gu avatar Jul 31 '23 12:07 eye-gu

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (d8c7b57) 60.99% compared to head (5631bb8) 60.97%.

Files Patch % Lines
...he/shenyu/loadbalancer/spi/RandomLoadBalancer.java 30.76% 7 Missing and 2 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4935      +/-   ##
============================================
- Coverage     60.99%   60.97%   -0.03%     
+ Complexity     8622     8621       -1     
============================================
  Files          1258     1258              
  Lines         38426    38424       -2     
  Branches       3679     3680       +1     
============================================
- Hits          23439    23428      -11     
- Misses        12871    12882      +11     
+ Partials       2116     2114       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 31 '23 13:07 codecov-commenter

pending next version~

moremind avatar Aug 03 '23 02:08 moremind

pending next version~

All right. But I have a question, Why does CI always fail?

eye-gu avatar Aug 03 '23 03:08 eye-gu

pending next version~

All right. But I have a question, Why does CI always fail?

e2e testing has a bug

moremind avatar Aug 03 '23 03:08 moremind