shenyu icon indicating copy to clipboard operation
shenyu copied to clipboard

[type:refactor] refactor shenyu-admin sync data listener.

Open yunlongn opened this issue 3 years ago • 1 comments

refactor shenyu-admin sync data listener. abstract Template

Make sure that:

  • [x] You have read the contribution guidelines.
  • [x] You submit test cases (unit or integration tests) that back your changes.
  • [x] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

yunlongn avatar Sep 14 '22 07:09 yunlongn

Codecov Report

Merging #3940 (89793f1) into master (7fbe081) will decrease coverage by 0.19%. The diff coverage is 96.24%.

@@             Coverage Diff              @@
##             master    #3940      +/-   ##
============================================
- Coverage     70.41%   70.22%   -0.20%     
+ Complexity     6743     6686      -57     
============================================
  Files           922      924       +2     
  Lines         25293    25099     -194     
  Branches       2287     2270      -17     
============================================
- Hits          17811    17625     -186     
+ Misses         6114     6107       -7     
+ Partials       1368     1367       -1     
Impacted Files Coverage Δ
...stener/zookeeper/ZookeeperDataChangedListener.java 81.81% <ø> (-8.85%) :arrow_down:
...dmin/listener/AbstractNodeDataChangedListener.java 92.95% <92.95%> (ø)
...dmin/listener/AbstractListDataChangedListener.java 97.36% <97.36%> (ø)
...min/listener/consul/ConsulDataChangedListener.java 85.71% <100.00%> (-11.48%) :arrow_down:
...min/listener/etcd/EtcdDataDataChangedListener.java 100.00% <100.00%> (+8.33%) :arrow_up:
...admin/listener/nacos/NacosDataChangedListener.java 53.33% <100.00%> (-40.15%) :arrow_down:
...shenyu/sync/data/consul/ConsulSyncDataService.java 78.33% <0.00%> (-1.67%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 14 '22 07:09 codecov-commenter