[ISSUE #3805] Add convenience annotation for tars
Subtask of #3805
Make sure that:
- [x] You have read the contribution guidelines.
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed
./mvnw clean install -Dmaven.javadoc.skip=true.
Hi, I think I'm getting some trouble that I've searched but cannot resolve without submitting another PR to TarsJava.
In Tars's SpringBootAppContext.class, it uses AnnotationUtils#getAnnotation to get the TarsServant annotation, which will return TarsServant{name = "", value = ""} instead the one with aliased value. It should be changed to use AnnotatedElementUtils#findMergedAnnotation, this won't break its original capability.
Should I submit a PR to TarsJava first? Any suggestions?
Hi, I think I'm getting some trouble that I've searched but cannot resolve without submitting another PR to TarsJava.
In Tars's SpringBootAppContext.class, it uses
AnnotationUtils#getAnnotationto get theTarsServantannotation, which will returnTarsServant{name = "", value = ""}instead the one with aliased value. It should be changed to useAnnotatedElementUtils#findMergedAnnotation, this won't break its original capability.Should I submit a PR to TarsJava first? Any suggestions?
I think so. Don't hesitate to submit PR to tars.
Codecov Report
Merging #3891 (a6ec442) into master (a9ae18a) will increase coverage by
0.01%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #3891 +/- ##
============================================
+ Coverage 69.59% 69.60% +0.01%
- Complexity 7350 7356 +6
============================================
Files 989 989
Lines 27797 27798 +1
Branches 2467 2467
============================================
+ Hits 19345 19350 +5
+ Misses 6982 6978 -4
Partials 1470 1470
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...enyu/client/tars/TarsServiceBeanEventListener.java | 88.75% <100.00%> (+0.14%) |
:arrow_up: |
| ...ruptor/RegisterClientServerDisruptorPublisher.java | 64.70% <0.00%> (+11.76%) |
:arrow_up: |
| ...controller/ShenyuClientHttpRegistryController.java | 100.00% <0.00%> (+22.22%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@HeZean please add wechat Z18179469818
@HeZean TarsJava 1.7.3 has released, you can continue.
too long time ,it be close.