shenyu icon indicating copy to clipboard operation
shenyu copied to clipboard

[ISSUE #3805] Add simpler client annotations for motan

Open runqi-zhao opened this issue 3 years ago • 5 comments

https://github.com/apache/shenyu/issues/3805

Make sure that:

  • [x] You have read the contribution guidelines.
  • [ ] You submit test cases (unit or integration tests) that back your changes.
  • [x] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

runqi-zhao avatar Aug 29 '22 12:08 runqi-zhao

Codecov Report

Merging #3889 (1cd4d45) into master (22546ae) will decrease coverage by 0.34%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3889      +/-   ##
============================================
- Coverage     65.99%   65.64%   -0.35%     
+ Complexity     6265     6239      -26     
============================================
  Files           900      901       +1     
  Lines         24901    24934      +33     
  Branches       2244     2245       +1     
============================================
- Hits          16434    16369      -65     
- Misses         7082     7186     +104     
+ Partials       1385     1379       -6     
Impacted Files Coverage Δ
...n/alibaba/dubbo/cache/AlibabaDubboConfigCache.java 47.12% <0.00%> (-31.04%) :arrow_down:
...controller/ShenyuClientHttpRegistryController.java 77.77% <0.00%> (-22.23%) :arrow_down:
...ruptor/RegisterClientServerDisruptorPublisher.java 52.94% <0.00%> (-11.77%) :arrow_down:
...che/shenyu/admin/model/entity/DashboardUserDO.java 66.66% <0.00%> (-7.41%) :arrow_down:
.../apache/shenyu/admin/model/dto/BatchCommonDTO.java 50.00% <0.00%> (-7.15%) :arrow_down:
...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java 57.14% <0.00%> (-7.15%) :arrow_down:
...org/apache/shenyu/admin/model/dto/AuthPathDTO.java 58.82% <0.00%> (-5.89%) :arrow_down:
...nyu/plugin/motan/cache/ApplicationConfigCache.java 52.00% <0.00%> (-5.00%) :arrow_down:
...enyu/admin/controller/DashboardUserController.java 71.87% <0.00%> (-4.80%) :arrow_down:
...u/admin/service/impl/DashboardUserServiceImpl.java 79.24% <0.00%> (-4.76%) :arrow_down:
... and 24 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 29 '22 13:08 codecov-commenter

check https://github.com/apache/shenyu/pull/3818 for some useful information.

ShenyuMotanService should be a derived annotation of com.weibo.api.motan.config.springsupport.annotation.MotanService and org.apache.shenyu.client.motan.common.annotation.ShenyuMotanClient.

loongs-zhang avatar Aug 30 '22 03:08 loongs-zhang

@runqi-zhao please add wechat Z18179469818

loongs-zhang avatar Aug 31 '22 05:08 loongs-zhang

motan dosc not supports @AliasFor for now.

loongs-zhang avatar Aug 31 '22 06:08 loongs-zhang

see https://github.com/weibocom/motan/issues/993 , @AliasFor will be supported in 2 months in motan.

loongs-zhang avatar Sep 06 '22 10:09 loongs-zhang

please update motan to 1.2.0

loongs-zhang avatar Oct 19 '22 06:10 loongs-zhang