setNextException with chain in classes JDBCBackendTransactionManager …
…and LocalTransactionManager
Fixes #20810.
Changes proposed in this pull request:
- setNextException with chain in JDBCBackendTransactionManager.class
- setNextException with chain in LocalTransactionManager.class -
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the code of conduct of this project.
- [x] I have self-reviewed the commit code.
- [x] I have triggered maven check:
mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e. - [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
Codecov Report
Merging #21076 (cea25a3) into master (22d5297) will increase coverage by
0.00%. The diff coverage is0.00%.
@@ Coverage Diff @@
## master #21076 +/- ##
=========================================
Coverage 61.56% 61.57%
Complexity 2507 2507
=========================================
Files 4089 4089
Lines 56616 56612 -4
Branches 7489 7489
=========================================
+ Hits 34856 34859 +3
+ Misses 18841 18834 -7
Partials 2919 2919
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...ine/core/task/InventoryIncrementalTasksRunner.java | 0.00% <ø> (ø) |
|
| ...dbc/transaction/JDBCBackendTransactionManager.java | 48.00% <0.00%> (+1.24%) |
:arrow_up: |
| ...tion/jdbc/transaction/LocalTransactionManager.java | 50.00% <0.00%> (+2.00%) |
:arrow_up: |
| ...handler/distsql/ral/hint/enums/HintSourceType.java | 42.85% <0.00%> (+42.85%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Please resolve conflicts
Please resolve conflicts
@terrymanu resolved conflicts. Please review
Please check the code @null-sys .In the original logic, the input parameter [ex1, ex2],then the method will return ex1 and ex1.next = ex2;After your change,the input parameter [ex1, ex2],then the method will return ex2 and ex2.next = ex1;It's not same.
Please check the code @null-sys .In the original logic, the input parameter
[ex1, ex2],then the method will returnex1 and ex1.next = ex2;After your change,the input parameter[ex1, ex2],then the method will returnex2 and ex2.next = ex1;It's not same.
@FlyingZC , As I understood, that was the indented change to recursively add these errors
Fixed at #23668