seatunnel icon indicating copy to clipboard operation
seatunnel copied to clipboard

[SeaTunnel][Connector-v2][Doris]Support Doris Sink.

Open hk-lrzy opened this issue 3 years ago • 17 comments

Purpose of this pull request

Check list

  • [ ] Code changed are covered with tests, or it does not need tests for reason:
  • [ ] If any new Jar binary package adding in your PR, please add License Notice according New License Guide
  • [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

hk-lrzy avatar Aug 31 '22 16:08 hk-lrzy

@xtr1993 Hi, PTAL,thx

CalvinKirs avatar Sep 01 '22 00:09 CalvinKirs

flink

Sure, i am try to do this job at same time, but there have no avaliable docker image for doris now.

hk-lrzy avatar Sep 01 '22 04:09 hk-lrzy

This situation (because the framework itself is not integrated) requires us to create it manually. FYI : https://www.testcontainers.org/features/creating_images/ On 09/1/2022 @.***> wrote:

flink

Sure, i am try to , but there have no avaliable docker image for doris now.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

CalvinKirs avatar Sep 01 '22 07:09 CalvinKirs

This situation (because the framework itself is not integrated) requires us to create it manually. FYI : https://www.testcontainers.org/features/creating_images/ On 09/1/2022 @.> wrote: flink Sure, i am try to , but there have no avaliable docker image for doris now. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.>

Thanks, i am already try to build image by myself, and it will push to dockerhub.

hk-lrzy avatar Sep 01 '22 07:09 hk-lrzy

Thanks, i am already try to build image by myself, and it will push to dockerhub.

Hi, are there any issues with existing doris images on docker hub? On 09/1/2022 @.***> wrote:

CalvinKirs avatar Sep 01 '22 07:09 CalvinKirs

Thanks, i am already try to build image by myself, and it will push to dockerhub. Hi, are there any issues with existing doris images on docker hub? On 09/1/2022 @.***> wrote:

it's just use for build-env, you may see the image's tag like build-env-for-1.1.0

I test this pull request by deploy it by release package.

hk-lrzy avatar Sep 01 '22 12:09 hk-lrzy

Can you update the title of this pr and add Sink. Because I found this is a sink connector.

EricJoy2048 avatar Sep 02 '22 05:09 EricJoy2048

hk-lrzy avatar Sep 02 '22 07:09 hk-lrzy

@CalvinKirs @hailin0 @EricJoy2048 @jbonofre i already added e2e test for doris, plz take a look again

hk-lrzy avatar Sep 05 '22 05:09 hk-lrzy

Need to add spark e2e test

ic4y avatar Sep 07 '22 10:09 ic4y

Need to add spark e2e test

i already fix it, plz take a look again @ic4y

hk-lrzy avatar Sep 07 '22 11:09 hk-lrzy

@hailin0 I push a commit and resolve most of comments. can you take a look again, thanks a lot.

hk-lrzy avatar Sep 08 '22 12:09 hk-lrzy

@TyrantLucifer @EricJoy2048 Plz take a look again, if there have no any more questions, plz approve the pr, thanks a lot.

hk-lrzy avatar Sep 14 '22 12:09 hk-lrzy

@hailin0 I reply the comments.

hk-lrzy avatar Sep 14 '22 15:09 hk-lrzy

@hk-lrzy Please fix the CI error.

EricJoy2048 avatar Oct 13 '22 05:10 EricJoy2048

Since there has been no update for a long time, we decided to close this PR. If anyone is willing to complete it, please leave a message and let us know.

EricJoy2048 avatar Nov 02 '22 10:11 EricJoy2048

Please assign to me.

TaoZex avatar Nov 02 '22 11:11 TaoZex