rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

Slave's accessMessageInMemoryMaxRatio should be calculated dynamically

Open gaoyf opened this issue 10 months ago • 2 comments

Which Issue(s) This PR Fixes

Fixes #9275

Brief Description

How Did You Test This Change?

gaoyf avatar Mar 26 '25 09:03 gaoyf

Hello, May I ask you a question? When I create a new PR, it shows Review required At least 1 approving review is required by reviewers with write access. Do I have to do something or just wait? image

WJ66880 avatar Apr 10 '25 10:04 WJ66880

Hello, May I ask you a question? When I create a new PR, it shows Review required At least 1 approving review is required by reviewers with write access. Do I have to do something or just wait? image

Wait

gaoyf avatar Apr 14 '25 01:04 gaoyf

@RongtongJin 这个PR这么久了分配一下人review吧

gaoyf avatar Oct 15 '25 09:10 gaoyf

@RongtongJin 这个PR这么久了分配一下人review吧

可以先解决一下冲突

RongtongJin avatar Oct 15 '25 09:10 RongtongJin

我看develop分支已经删除了org.apache.rocketmq.broker.BrokerStartup下面的代码:

if (BrokerRole.SLAVE == messageStoreConfig.getBrokerRole()) {
    int ratio = messageStoreConfig.getAccessMessageInMemoryMaxRatio() - 10;
    messageStoreConfig.setAccessMessageInMemoryMaxRatio(ratio);
}

那么这个bug也就不存在了,我关闭这个pr了

gaoyf avatar Oct 16 '25 01:10 gaoyf