rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

Support LMQ dispatch in case if Consume Queue Store is RocksDB-based

Open lizhanhui opened this issue 1 year ago • 1 comments

Which Issue(s) This PR Fixes

to #8829

Brief Description

How Did You Test This Change?

lizhanhui avatar Oct 18 '24 11:10 lizhanhui

Codecov Report

Attention: Patch coverage is 42.55639% with 382 lines in your changes missing coverage. Please review.

Project coverage is 47.29%. Comparing base (1e0b08f) to head (b518616). Report is 41 commits behind head on develop.

Files with missing lines Patch % Lines
...ocketmq/broker/processor/AdminBrokerProcessor.java 37.90% 70 Missing and 7 partials :warning:
...rocketmq/broker/metrics/ConsumerLagCalculator.java 0.00% 43 Missing :warning:
...rocketmq/store/queue/RocksDBConsumeQueueStore.java 48.14% 34 Missing and 8 partials :warning:
...tieredstore/metrics/TieredStoreMetricsManager.java 0.00% 39 Missing :warning:
...mq/store/queue/RocksDBConsumeQueueOffsetTable.java 70.17% 21 Missing and 13 partials :warning:
...rocketmq/broker/processor/PopMessageProcessor.java 16.66% 20 Missing :warning:
...che/rocketmq/broker/metrics/PopMetricsManager.java 7.69% 12 Missing :warning:
...main/java/org/apache/rocketmq/store/CommitLog.java 45.00% 10 Missing and 1 partial :warning:
...ocketmq/store/exception/ConsumeQueueException.java 0.00% 10 Missing :warning:
...pache/rocketmq/store/exception/StoreException.java 0.00% 10 Missing :warning:
... and 21 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8842      +/-   ##
=============================================
- Coverage      47.46%   47.29%   -0.17%     
+ Complexity     11617    11610       -7     
=============================================
  Files           1284     1290       +6     
  Lines          90025    90293     +268     
  Branches       11585    11609      +24     
=============================================
- Hits           42728    42706      -22     
- Misses         42061    42314     +253     
- Partials        5236     5273      +37     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

codecov-commenter avatar Oct 20 '24 02:10 codecov-commenter

@LetLetMe PTAL~

RongtongJin avatar Oct 21 '24 03:10 RongtongJin

@redlsz @leizhiyuan Please also take a look

lizhanhui avatar Oct 21 '24 09:10 lizhanhui

LGTM

tianliuliu avatar Oct 27 '24 05:10 tianliuliu