rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #8123] Support bitmap filter for Static Subscription

Open drpmma opened this issue 1 year ago • 3 comments

Which Issue(s) This PR Fixes

Fixes #8123

Brief Description

Support bitmap filter for Static Subscription

How Did You Test This Change?

Integration test

drpmma avatar May 13 '24 08:05 drpmma

Codecov Report

Attention: Patch coverage is 20.51282% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 42.86%. Comparing base (159a603) to head (c9fc716). Report is 4 commits behind head on develop.

Files Patch % Lines
...a/org/apache/rocketmq/broker/BrokerController.java 0.00% 10 Missing and 1 partial :warning:
...ocketmq/broker/processor/AdminBrokerProcessor.java 10.00% 8 Missing and 1 partial :warning:
...rocketmq/broker/processor/PopMessageProcessor.java 0.00% 3 Missing :warning:
...roker/client/DefaultConsumerIdsChangeListener.java 66.66% 0 Missing and 2 partials :warning:
...ocketmq/broker/processor/PullMessageProcessor.java 0.00% 2 Missing :warning:
.../rocketmq/broker/filter/ConsumerFilterManager.java 66.66% 0 Missing and 1 partial :warning:
...rocketmq/broker/metrics/ConsumerLagCalculator.java 0.00% 1 Missing :warning:
...e/rocketmq/remoting/protocol/filter/FilterAPI.java 0.00% 0 Missing and 1 partial :warning:
...n/java/org/apache/rocketmq/store/ConsumeQueue.java 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8125      +/-   ##
=============================================
- Coverage      42.94%   42.86%   -0.09%     
+ Complexity     10387    10368      -19     
=============================================
  Files           1270     1270              
  Lines          88694    88720      +26     
  Branches       11401    11411      +10     
=============================================
- Hits           38092    38030      -62     
- Misses         45914    45988      +74     
- Partials        4688     4702      +14     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 13 '24 09:05 codecov-commenter

如果 pull 请求带的过滤表达式和 register 的不一致行为是什么?

lizhimins avatar May 16 '24 11:05 lizhimins

The filter with pull requests will take effect when get messages.

drpmma avatar May 16 '24 11:05 drpmma

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar May 17 '25 00:05 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar May 20 '25 00:05 github-actions[bot]