rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #7724] Fix revive incorrect message when the original message is not alive

Open redlsz opened this issue 2 years ago • 2 comments

Which Issue(s) This PR Fixes

Fixes #7724

Brief Description

Check the offset of got message before reviving it.

redlsz avatar Jan 10 '24 10:01 redlsz

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3f99b1e) 43.19% compared to head (436e2ac) 43.14%. Report is 4 commits behind head on develop.

Files Patch % Lines
...he/rocketmq/broker/processor/PopReviveService.java 0.00% 4 Missing :warning:
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7739      +/-   ##
=============================================
- Coverage      43.19%   43.14%   -0.05%     
+ Complexity      9829     9823       -6     
=============================================
  Files           1166     1167       +1     
  Lines          84564    84611      +47     
  Branches       10985    10974      -11     
=============================================
- Hits           36527    36509      -18     
- Misses         43499    43568      +69     
+ Partials        4538     4534       -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 10 '24 11:01 codecov-commenter

CompletableFuture<Pair<Long, Boolean>> future = getBizMessage(popCheckPoint.getTopic(), msgOffset, popCheckPoint.getQueueId(), popCheckPoint.getBrokerName())

这里建议加个注释,Boolean 表示消费结果,false 时需要 rePutCk()

ok,加了

redlsz avatar Jan 12 '24 06:01 redlsz