rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #7671] filter inner producer client when report to metrics

Open zhiliatom opened this issue 2 years ago • 2 comments

Which Issue(s) This PR Fixes

Fixes #7671

Brief Description

How Did You Test This Change?

zhiliatom avatar Dec 18 '23 07:12 zhiliatom

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (71a7a65) 43.17% compared to head (6decae3) 43.13%. Report is 4 commits behind head on develop.

Files Patch % Lines
.../rocketmq/broker/metrics/BrokerMetricsManager.java 0.00% 7 Missing :warning:
...main/java/org/apache/rocketmq/store/CommitLog.java 25.00% 5 Missing and 1 partial :warning:
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 40.00% 3 Missing :warning:
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7673      +/-   ##
=============================================
- Coverage      43.17%   43.13%   -0.05%     
- Complexity      9797     9798       +1     
=============================================
  Files           1165     1165              
  Lines          84477    84486       +9     
  Branches       10966    10968       +2     
=============================================
- Hits           36474    36441      -33     
- Misses         43473    43516      +43     
+ Partials        4530     4529       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 18 '23 07:12 codecov-commenter

@ShadowySpirits take a look at this pr

zhiliatom avatar Dec 29 '23 09:12 zhiliatom