rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #7651] Support to send trace for batchSend

Open cserwen opened this issue 2 years ago • 5 comments

Which Issue(s) This PR Fixes

Fixes #7651

Brief Description

Make SendMessageTraceHookImpl support processing batch messages

How Did You Test This Change?

unit-test

cserwen avatar Dec 13 '23 04:12 cserwen

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 42.82%. Comparing base (a376fbc) to head (d8cc24d). Report is 97 commits behind head on develop.

Files Patch % Lines
...mq/client/trace/hook/SendMessageTraceHookImpl.java 88.09% 1 Missing and 4 partials :warning:
...g/apache/rocketmq/common/message/MessageBatch.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7652      +/-   ##
=============================================
- Coverage      43.19%   42.82%   -0.37%     
- Complexity      9812    10355     +543     
=============================================
  Files           1165     1270     +105     
  Lines          84461    88670    +4209     
  Branches       10964    11404     +440     
=============================================
+ Hits           36482    37976    +1494     
- Misses         43454    46003    +2549     
- Partials        4525     4691     +166     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 13 '23 04:12 codecov-commenter

LGTM~

humkum avatar Jan 11 '24 06:01 humkum

LGTM

There will be significant improvement in the performance of the trajectory.

leizhiyuan avatar Jan 11 '24 11:01 leizhiyuan

LGTM

There will be significant improvement in the performance of the trajectory.

Need to approve it, lol @leizhiyuan

cserwen avatar Jan 12 '24 09:01 cserwen

@lizhimins Please help me review this code :-D

cserwen avatar Mar 22 '24 08:03 cserwen