rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #7540] Fix query offset of compaction topic

Open redlsz opened this issue 2 years ago • 3 comments

Which Issue(s) This PR Fixes

Fixes #7540

Brief Description

Check the cleanup policy of the topic when processing offset query request in message store.

redlsz avatar Nov 06 '23 13:11 redlsz

Codecov Report

Merging #7541 (7501bb5) into develop (46962c2) will increase coverage by 0.29%. Report is 1 commits behind head on develop. The diff coverage is 80.00%.

@@              Coverage Diff              @@
##             develop    #7541      +/-   ##
=============================================
+ Coverage      42.97%   43.26%   +0.29%     
- Complexity      9677     9738      +61     
=============================================
  Files           1158     1158              
  Lines          83987    84020      +33     
  Branches       10917    10923       +6     
=============================================
+ Hits           36093    36353     +260     
+ Misses         43399    43146     -253     
- Partials        4495     4521      +26     
Files Coverage Δ
...ocketmq/broker/processor/SendMessageProcessor.java 37.13% <100.00%> (+0.84%) :arrow_up:
...rocketmq/common/message/MessageExtBrokerInner.java 28.57% <100.00%> (-27.43%) :arrow_down:
...pache/rocketmq/store/kv/CompactionPositionMgr.java 83.33% <100.00%> (ø)
...in/java/org/apache/rocketmq/common/KeyBuilder.java 0.00% <0.00%> (ø)
...org/apache/rocketmq/common/utils/MessageUtils.java 61.11% <88.00%> (+61.11%) :arrow_up:
...org/apache/rocketmq/store/DefaultMessageStore.java 46.85% <75.00%> (+0.21%) :arrow_up:
.../org/apache/rocketmq/store/kv/CompactionStore.java 49.13% <64.28%> (+17.40%) :arrow_up:

... and 38 files with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codecov-commenter avatar Nov 06 '23 13:11 codecov-commenter

@ltamber PTAL

redlsz avatar Nov 06 '23 13:11 redlsz

any update?

leizhiyuan avatar Jan 10 '24 08:01 leizhiyuan