rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #7263& ISSUE #7264] Fix to cleanup consumption offset data or topic consumerqueue on the standby node when execute command 'deleteSubGroup' or 'deleteTopic'

Open frinda opened this issue 2 years ago • 10 comments

Which Issue(s) This PR Fixes

Fixes #7263 and #7264

Brief Description

How Did You Test This Change?

frinda avatar Aug 28 '23 01:08 frinda

Codecov Report

Merging #7273 (5aea257) into develop (b4f73e2) will increase coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             develop    #7273   +/-   ##
==========================================
  Coverage      42.62%   42.62%           
+ Complexity      9414     9413    -1     
==========================================
  Files           1152     1152           
  Lines          82355    82358    +3     
  Branches       10723    10723           
==========================================
+ Hits           35100    35105    +5     
- Misses         42874    42876    +2     
+ Partials        4381     4377    -4     
Files Changed Coverage Δ
...apache/rocketmq/broker/slave/SlaveSynchronize.java 4.08% <0.00%> (-0.09%) :arrow_down:

... and 36 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 28 '23 02:08 codecov-commenter

lgtm

this bothers me too. I copy master's consumerqueue data to slave and restart slave to fix

iamgd67 avatar Nov 08 '23 07:11 iamgd67

seek for integration

frinda avatar Nov 30 '23 03:11 frinda

I think the title might be too long, suggest renaming [ISSUE xx& ISSUE xxx] Fix: xxx

@ joeCarf It's been changed. Please submit it,Thanks

frinda avatar Dec 04 '23 07:12 frinda

I think the title might be too long, suggest renaming [ISSUE xx& ISSUE xxx] Fix: xxx

@ joeCarf It's been changed. Please submit it,Thanks

still too long, maybe this?

[ISSUE #7263& ISSUE #7264] consumption offset data and topic consumerqueue not deleted on the standby node

iamgd67 avatar Dec 04 '23 07:12 iamgd67

I think the title might be too long, suggest renaming [ISSUE xx& ISSUE xxx] Fix: xxx

@ joeCarf It's been changed. Please submit it,Thanks

still too long, maybe this?

[ISSUE #7263& ISSUE #7264] consumption offset data and topic consumerqueue not deleted on the standby node

has changed

frinda avatar Dec 07 '23 06:12 frinda

I think the title might be too long, suggest renaming [ISSUE xx& ISSUE xxx] Fix: xxx

@joeCarf seek for integration

frinda avatar Dec 07 '23 06:12 frinda

Begging to join

frinda avatar Dec 09 '23 03:12 frinda

@mxsm @Oliverwqcwrw Help to integrate the code.

frinda avatar Dec 11 '23 01:12 frinda

lgtm

zhiliatom avatar Jun 04 '24 10:06 zhiliatom