rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #7131] Replace java.nio.ByteBuffer with class name

Open zhiliatom opened this issue 2 years ago • 4 comments

Fixes #7131

Brief Description

How Did You Test This Change?

zhiliatom avatar Aug 08 '23 07:08 zhiliatom

LGTM

RongtongJin avatar Aug 23 '23 00:08 RongtongJin

Hi, I've read the log but can't understand why it building fail, cause I havn't modify any code actually. @joeCarf @RongtongJin

zhiliatom avatar Aug 25 '23 13:08 zhiliatom

@RongtongJin Pay attention to this patch, can it be merged?

zhiliatom avatar Sep 15 '23 01:09 zhiliatom

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (c2c29c2) 43.20% compared to head (5a3cddd) 43.17%. Report is 1 commits behind head on develop.

Files Patch % Lines
...apache/rocketmq/store/timer/TimerMessageStore.java 20.00% 4 Missing :warning:
...apache/rocketmq/broker/slave/SlaveSynchronize.java 0.00% 3 Missing :warning:
...pache/rocketmq/common/message/MessageAccessor.java 0.00% 3 Missing :warning:
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7132      +/-   ##
=============================================
- Coverage      43.20%   43.17%   -0.03%     
- Complexity      9796     9799       +3     
=============================================
  Files           1164     1164              
  Lines          84420    84428       +8     
  Branches       10961    10963       +2     
=============================================
- Hits           36474    36456      -18     
- Misses         43420    43447      +27     
+ Partials        4526     4525       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 08 '23 06:12 codecov-commenter