rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #6086] Add topic startwith rmq_sys_ in getSystemTopicListFromB…

Open zhiliatom opened this issue 2 years ago • 2 comments

Brief changelog

fix #6086

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

zhiliatom avatar Feb 16 '23 03:02 zhiliatom

Codecov Report

Merging #6089 (e0aa67e) into develop (f9a4dfb) will increase coverage by 0.02%. The diff coverage is 32.25%.

@@              Coverage Diff              @@
##             develop    #6089      +/-   ##
=============================================
+ Coverage      43.23%   43.25%   +0.02%     
- Complexity      8845     8849       +4     
=============================================
  Files           1094     1094              
  Lines          77102    77139      +37     
  Branches       10055    10057       +2     
=============================================
+ Hits           33333    33365      +32     
- Misses         39603    39616      +13     
+ Partials        4166     4158       -8     
Impacted Files Coverage Δ
...a/org/apache/rocketmq/broker/BrokerController.java 43.25% <0.00%> (ø)
...ocketmq/broker/processor/AdminBrokerProcessor.java 25.28% <0.00%> (-0.04%) :arrow_down:
...a/org/apache/rocketmq/client/impl/MQAdminImpl.java 4.95% <0.00%> (+0.02%) :arrow_up:
...he/rocketmq/controller/impl/DLedgerController.java 66.49% <ø> (ø)
...tmq/proxy/processor/DefaultMessagingProcessor.java 2.89% <0.00%> (-0.14%) :arrow_down:
...ketmq/remoting/metrics/RemotingMetricsManager.java 15.38% <0.00%> (-1.29%) :arrow_down:
.../org/apache/rocketmq/proxy/config/ProxyConfig.java 44.52% <25.00%> (-0.14%) :arrow_down:
...q/tieredstore/common/TieredMessageStoreConfig.java 65.54% <25.00%> (-4.92%) :arrow_down:
.../rocketmq/broker/metrics/BrokerMetricsManager.java 12.21% <30.00%> (+0.62%) :arrow_up:
.../apache/rocketmq/tieredstore/TieredDispatcher.java 45.00% <33.33%> (ø)
... and 26 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Feb 16 '23 03:02 codecov-commenter

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Feb 17 '24 00:02 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Feb 20 '24 00:02 github-actions[bot]