rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #5844] Fix bug when examine pop consumer group info

Open HScarb opened this issue 2 years ago • 2 comments

Make sure set the target branch to develop

What is the purpose of the change

Fix #5844

Brief changelog

Use examineBrokerClusterInfo instead of examine retry topic route info when examing broker addrs in examingConsumeStats and examingConsumerConnectionInfo methods.

Verifying this change

image

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

HScarb avatar Jan 30 '23 12:01 HScarb

Codecov Report

Merging #5956 (53a08bb) into develop (eef581b) will decrease coverage by 0.01%. The diff coverage is 68.42%.

@@              Coverage Diff              @@
##             develop    #5956      +/-   ##
=============================================
- Coverage      42.93%   42.93%   -0.01%     
+ Complexity      8995     8992       -3     
=============================================
  Files           1104     1104              
  Lines          78380    78373       -7     
  Branches       10207    10206       -1     
=============================================
- Hits           33654    33647       -7     
+ Misses         40512    40503       -9     
- Partials        4214     4223       +9     
Impacted Files Coverage Δ
...he/rocketmq/tools/admin/DefaultMQAdminExtImpl.java 25.42% <68.42%> (+0.31%) :arrow_up:

... and 27 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar May 23 '23 10:05 codecov-commenter

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar May 23 '24 00:05 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar May 26 '24 00:05 github-actions[bot]