rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

Enable checkstyle for test code

Open aaron-ai opened this issue 3 years ago • 2 comments

To improve the quality of test code, checkstyle should be enabled.

  <executions>
      <execution>
          <id>verify</id>
          <phase>verify</phase>
          <configuration>
              <configLocation>style/rmq_checkstyle.xml</configLocation>
              <encoding>UTF-8</encoding>
              <consoleOutput>true</consoleOutput>
              <failsOnError>true</failsOnError>
              <!-- test checkstyle is disabled here -->
              <includeTestSourceDirectory>false</includeTestSourceDirectory>
          </configuration>
          <goals>
              <goal>check</goal>
          </goals>
      </execution>
  </executions>

aaron-ai avatar Sep 20 '22 01:09 aaron-ai

i will make it.

nowinkeyy avatar Sep 20 '22 06:09 nowinkeyy

i will make it.

Nice! I assigned it to you.

aaron-ai avatar Sep 20 '22 06:09 aaron-ai

Hi @aaron-ai. I submitted a PR for this isse. #5166

nowinkeyy avatar Sep 23 '22 01:09 nowinkeyy