using caffeine replace guava cache
Make sure set the target branch to develop
What is the purpose of the change
using caffeine replace guava cache
Brief changelog
using caffeine replace guava cache
Verifying this change
TopicRouteService class
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.
- [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
- [x] Run
mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
Coverage decreased (-0.2%) to 48.761% when pulling c8a337ef3365712e706249444ab4ba1f7fa4796b on fuyou001:optimizing-cache into 4b5270a724d100ab87f56fdd06a4ba57571a02b9 on apache:develop.
Codecov Report
Merging #4669 (7bfba8a) into develop (0d1eec2) will decrease coverage by
0.15%. The diff coverage is55.66%.
@@ Coverage Diff @@
## develop #4669 +/- ##
=============================================
- Coverage 45.04% 44.89% -0.16%
- Complexity 7613 7632 +19
=============================================
Files 977 978 +1
Lines 67778 68069 +291
Branches 8959 9001 +42
=============================================
+ Hits 30533 30559 +26
- Misses 33478 33721 +243
- Partials 3767 3789 +22
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...apache/rocketmq/broker/BrokerPreOnlineService.java | 0.00% <0.00%> (ø) |
|
| ...ocol/header/namesrv/GetRouteInfoRequestHeader.java | 0.00% <ø> (ø) |
|
| ...tmq/namesrv/processor/DefaultRequestProcessor.java | 58.88% <ø> (-2.91%) |
:arrow_down: |
| ...rocketmq/remoting/netty/NettyRemotingAbstract.java | 53.95% <0.00%> (-0.17%) |
:arrow_down: |
| ...apache/rocketmq/store/timer/TimerMessageStore.java | 54.18% <36.36%> (+0.08%) |
:arrow_up: |
| ...a/org/apache/rocketmq/broker/BrokerController.java | 46.52% <66.66%> (-0.04%) |
:arrow_down: |
| ...ocketmq/proxy/service/route/TopicRouteService.java | 65.38% <71.42%> (-15.57%) |
:arrow_down: |
| ...etmq/namesrv/processor/ClientRequestProcessor.java | 70.37% <73.33%> (+25.37%) |
:arrow_up: |
| ...g/apache/rocketmq/store/timer/TimerCheckpoint.java | 91.39% <90.90%> (+24.73%) |
:arrow_up: |
| ...ntroller/processor/ControllerRequestProcessor.java | 24.17% <0.00%> (-22.64%) |
:arrow_down: |
| ... and 59 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more