rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

remove redundant logic

Open zhiliatom opened this issue 3 years ago • 2 comments

Make sure set the target branch to develop

What is the purpose of the change

fix #4658

zhiliatom avatar Jul 22 '22 06:07 zhiliatom

Codecov Report

Merging #4659 (6eb2688) into develop (3a1d1a7) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #4659      +/-   ##
=============================================
+ Coverage      44.75%   44.77%   +0.02%     
- Complexity      7526     7527       +1     
=============================================
  Files            975      975              
  Lines          67378    67376       -2     
  Branches        8892     8891       -1     
=============================================
+ Hits           30153    30169      +16     
+ Misses         33504    33495       -9     
+ Partials        3721     3712       -9     
Impacted Files Coverage Δ
...mq/client/impl/producer/DefaultMQProducerImpl.java 44.48% <ø> (+0.10%) :arrow_up:
...q/tools/command/acl/GetAccessConfigSubCommand.java 19.60% <100.00%> (ø)
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) :arrow_down:
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) :arrow_down:
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-8.70%) :arrow_down:
...etmq/namesrv/routeinfo/BatchUnRegisterService.java 94.73% <0.00%> (-5.27%) :arrow_down:
...va/org/apache/rocketmq/common/stats/StatsItem.java 52.50% <0.00%> (-2.50%) :arrow_down:
...ache/rocketmq/store/AllocateMappedFileService.java 39.28% <0.00%> (-2.39%) :arrow_down:
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) :arrow_down:
...client/consumer/store/RemoteBrokerOffsetStore.java 68.14% <0.00%> (-0.89%) :arrow_down:
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

codecov-commenter avatar Jul 22 '22 06:07 codecov-commenter

Coverage Status

Coverage increased (+0.1%) to 49.136% when pulling 6967d1ae5e14843d023b8d0b4292ec96aa5a13d4 on meateggmilk:fix_code_style into 3a1d1a7e60f9049fb7e5048a9f08cdcdbf996601 on apache:develop.

coveralls avatar Jul 22 '22 07:07 coveralls

Got it, thx

zhiliatom avatar Aug 23 '22 13:08 zhiliatom