rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[iSSUE-4256] Concurrent execution of methods that support DefaultMQAdminExtImpl

Open kaori-seasons opened this issue 3 years ago • 4 comments

Make sure set the target branch to develop

What is the purpose of the change

Related to issue-4256

DefaultMQAdminExtImpl is also optimized. DefaultMQAdminExtImpl has a lot of additions, deletions, modification and query operations, but many operations are implemented through serial traversal. 5.0.0-beta has completed some parallel improvements to the API, such as the implementation of various Concurrent suffixes, but some are still serially OK, such as cleanUnusedTopic, the following current serial APIs need to be changed to concurrent execution in DefaultMQAdminExtImpl

Brief changelog

XX

Verifying this change

DefaultMQAdminExtTest#xxxxConcurrent

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

kaori-seasons avatar May 29 '22 05:05 kaori-seasons

image Please check why this test is wrong

hzh0425 avatar Jun 05 '22 03:06 hzh0425

image Please check why this test is wrong

At present, the unit test has not been completed. There is still a problem that the unit test thread times out when querying the nameserver. It is being resolved

kaori-seasons avatar Jun 06 '22 12:06 kaori-seasons

The currently added unit test will involve the operation of the IntegrationTestBase class of the test module. But the current test is in the tools module, which needs to be compatible. For example, in 5.0.0-beta, there will be interactions with broker and namesrv. In view of the fact that adding unit tests in the current pull request requires the help of this class, I will create a new one. an issue discussing this

kaori-seasons avatar Jun 19 '22 16:06 kaori-seasons

I'll wait until issue-4499 is resolved to simulate relevant concurrency test scenarios .

kaori-seasons avatar Jun 22 '22 06:06 kaori-seasons

Hi,could you resolve the code style error first? Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.2.0:check (validate) on project rocketmq-tools: Failed during checkstyle execution: There are 7 errors reported by Checkstyle 9.3 with /home/runner/work/rocketmq/rocketmq/style/rmq_checkstyle.xml ruleset. -> [Help 1]

Maybe it's because of the conflict, I'll fix it this week

kaori-seasons avatar Oct 08 '22 13:10 kaori-seasons

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Oct 09 '23 00:10 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Oct 13 '23 00:10 github-actions[bot]