rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[#3907]perf: Make `lastUpdateTimestamp` volatile so that the expiration task would see this quicker

Open xdshent opened this issue 3 years ago • 1 comments

reference Eureka

#3907

xdshent avatar Mar 01 '22 14:03 xdshent

Coverage Status

Coverage decreased (-0.02%) to 49.144% when pulling 7b8f7b06d10b12313a7b5c65c56586dd10c7ae26 on xdshent:develop into 9b87205c6d44e1c08aa5ae9aee6f2b28a60bb586 on apache:develop.

coveralls avatar Mar 01 '22 15:03 coveralls

Codecov Report

Merging #3908 (7b8f7b0) into develop (9b87205) will decrease coverage by 0.24%. The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #3908      +/-   ##
=============================================
- Coverage      45.09%   44.84%   -0.25%     
+ Complexity      7645     7605      -40     
=============================================
  Files            977      977              
  Lines          67965    67965              
  Branches        8985     8985              
=============================================
- Hits           30646    30482     -164     
- Misses         33552    33698     +146     
- Partials        3767     3785      +18     
Impacted Files Coverage Δ
...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java 65.38% <ø> (-0.16%) :arrow_down:
.../broker/subscription/SubscriptionGroupManager.java 68.79% <0.00%> (-14.19%) :arrow_down:
...n/java/org/apache/rocketmq/test/util/StatUtil.java 16.19% <0.00%> (-14.09%) :arrow_down:
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-8.96%) :arrow_down:
...va/org/apache/rocketmq/logging/inner/Appender.java 29.21% <0.00%> (-7.87%) :arrow_down:
...etmq/namesrv/processor/ClientRequestProcessor.java 70.37% <0.00%> (-3.71%) :arrow_down:
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (-3.42%) :arrow_down:
...ache/rocketmq/broker/topic/TopicConfigManager.java 59.03% <0.00%> (-3.06%) :arrow_down:
...tmq/broker/longpolling/PullRequestHoldService.java 63.36% <0.00%> (-2.98%) :arrow_down:
...he/rocketmq/controller/impl/DLedgerController.java 70.32% <0.00%> (-2.75%) :arrow_down:
... and 23 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov-commenter avatar Aug 10 '22 10:08 codecov-commenter

PTAL~

xdshent avatar Mar 02 '23 10:03 xdshent

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Mar 02 '24 00:03 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Mar 05 '24 00:03 github-actions[bot]