[ISSUE #2931 ]fix and optimize methods for sending and storing batch message
Make sure set the target branch to develop
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
fix #2931
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.
- [ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
- [ ] Run
mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
Coverage increased (+0.008%) to 51.832% when pulling e728526d0cc6b4db93b85e443a188c307643956b on sunxi92:bugfix-batchmessage into aaa92a2e53d773c7f1d9e9f25e41709f6948fa83 on apache:master.
Codecov Report
Merging #2932 (e728526) into master (3ae2517) will decrease coverage by
0.00%. The diff coverage is96.77%.
@@ Coverage Diff @@
## master #2932 +/- ##
============================================
- Coverage 45.98% 45.98% -0.01%
+ Complexity 4320 4315 -5
============================================
Files 547 547
Lines 36236 36246 +10
Branches 4808 4807 -1
============================================
+ Hits 16663 16666 +3
- Misses 17490 17496 +6
- Partials 2083 2084 +1
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 3ae2517...e728526. Read the comment docs.
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
This PR was closed because it has been inactive for 3 days since being marked as stale.