rocketmq-operator icon indicating copy to clipboard operation
rocketmq-operator copied to clipboard
verified publisher icon apache

[ISSUE 38] Add nodeAffinity for nameService pod

Open shendongsd opened this issue 4 years ago • 4 comments

shendongsd avatar Jun 09 '21 13:06 shendongsd

@shendongsd Is there an issue related to this PR? Would you also support preferredDuringSchedulingIgnoredDuringExecution, or why not?

caigy avatar Aug 24 '21 12:08 caigy

@shendongsd Is there an issue related to this PR? Would you also support preferredDuringSchedulingIgnoredDuringExecution, or why not? the issues/38 is related to this PR，i will also support preferredDuringSchedulingIgnoredDuringExecution and improve and perfect this PR

shendongsd avatar Aug 28 '21 13:08 shendongsd

  1. I think abbreviations like reqDurSchIgnDurExe are not no clear, especially for new beginners of K8s. For example, 'req' is short for 'request' in most cases other than 'require'. I think it more clear to leave the full names defined in K8s.
  2. Could you provide the reason to remove go.mod? I don't think this deletion is related to the issue.

1、I changed the variable name and restored "go.mod"

shendongsd avatar Aug 31 '21 13:08 shendongsd

the user should be able to just mention the nodeAffinity in the CR, templating out each and every spec in the nodeAffinity, isn't a best practice in the operator.

nodeAffinity:
   ----
   ----

this is only needed in the CR.

AdheipSingh avatar Mar 25 '22 06:03 AdheipSingh