rocketmq-flink icon indicating copy to clipboard operation
rocketmq-flink copied to clipboard

Version below 4.6.0 does not support DefaultLitePullConsumer

Open deemogsw opened this issue 3 years ago • 7 comments

DefaultMQPullConsumer has been instead of by DefaultLitePullConsumer.After I rebase master into my develop branch,some mistakes have occurred.And my company uses version 4.3 image So I run the old version and everything is normal.I'm thing about the compatibility.After reading the documents,I found the following explanation. image Since not all version support LitePull.The generality of the code is very poor, and users need to spend a lot of effort merging the code to use the full functionality. If there is no particularly big improvement, is it necessary to replace way of pull? There are still many features to be added,some bugs to be fixed. See #63 So I think that resetting the commit of #46 is a good choice.After all of functions are available,It's not too late to replace CommonPull by LitePull in a new branch or tag.

deemogsw avatar Oct 27 '22 16:10 deemogsw

@SteNicholas @zhouxinyu Please pay attention to this problem,thanks

deemogsw avatar Oct 27 '22 16:10 deemogsw

Maybe It has another problems.For testing ,i run the V4.8 in docker container.But it is still failed image So I read the documents again.In Assign mode,consumer must assign MessageQueues before seek offset. image But #46 use like this: image

It use a subscribe mode.It alse use seek() function. I guess if the exception is caused by an api usage error.So i make a test like this. image

deemogsw avatar Oct 29 '22 17:10 deemogsw

is there any progress ?

gj-zhang avatar Jan 04 '23 03:01 gj-zhang

is there any progress ? The original contributors disappeared and have not fix this problem.Maintainer also rarely manage. You can visit my homepage for project of rocketMQ-flink-connector.This is the latest version we use in production.

deemogsw avatar Jan 10 '23 07:01 deemogsw

Hello @deemogsw, sorry for the late reply. If you have some fixes about the current version, could you please merge it to the upstream through a PR?

zhouxinyu avatar Jan 10 '23 07:01 zhouxinyu

Hello @deemogsw, sorry for the late reply. If you have some fixes about the current version, could you please merge it to the upstream through a PR?

Sorry, I don't know much about lite pull.I can fix known problems, but I can't solve hidden problems because we use a lower version with defaultMQPull.So I suggest supporting this feature in the new branch. I just removed the problematic PR and add some updates in our internal version.All of patches have been merged into this or waiting for merging.

deemogsw avatar Jan 10 '23 09:01 deemogsw

is there any progress ? The original contributors disappeared and have not fix this problem.Maintainer also rarely manage. You can visit my homepage for project of rocketMQ-flink-connector.This is the latest version we use in production.

Hello @deemogsw , your rocketMQ-flink-connector project solved my problem, thanks a lot~~ save me a lot of time.

kevinnerd avatar Aug 22 '23 06:08 kevinnerd