[ISSUE #67] Bugfix for consume blocking

Open deemogsw opened this issue 3 years ago • 1 comments

Is there a better idea

Oct 19 '22 15:10 deemogsw

Codecov Report

Merging #68 (961ab17) into main (90b00be) will decrease coverage by 0.03%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main      #68      +/-   ##
============================================
- Coverage     28.50%   28.47%   -0.04%     
  Complexity      164      164              
============================================
  Files            62       62              
  Lines          2529     2532       +3     
  Branches        269      270       +1     
============================================
  Hits            721      721              
- Misses         1741     1744       +3     
  Partials         67       67

Impacted Files	Coverage Δ
.../rocketmq/flink/legacy/RocketMQSourceFunction.java	`9.55% <ø> (ø)`
...e/rocketmq/flink/legacy/common/util/RetryUtil.java	`0.00% <0.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Oct 19 '22 15:10 codecov-commenter

LGTM. Thanks for @deemogsw contribution. BTW, @deemogsw have you tested this on local environment?

Yes,I have test this case.We found the bug in produce environment. We can simulate the case by throwing exception in RocketMQSourceFunction.open(). As #67 showed.

Oct 27 '22 12:10 deemogsw