rocketmq-client-go icon indicating copy to clipboard operation
rocketmq-client-go copied to clipboard

[ISSUE apache#931] fix filter message

Open 0daypwn opened this issue 3 years ago • 1 comments

What is the purpose of the change

close #931

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

0daypwn avatar Oct 10 '22 03:10 0daypwn

Codecov Report

Merging #932 (cc501ae) into master (92515f7) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #932   +/-   ##
=======================================
  Coverage   23.61%   23.61%           
=======================================
  Files          52       52           
  Lines        7170     7170           
=======================================
  Hits         1693     1693           
  Misses       5247     5247           
  Partials      230      230           
Impacted Files Coverage Δ
consumer/consumer.go 17.61% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 10 '22 03:10 codecov-commenter