rocketmq-client-go
rocketmq-client-go copied to clipboard
[ISSUE:#1131] `ctx` param not work for`consumer.pullFrom` method
What is the purpose of the change
fix: #1131
- the
ctxparam ofconsumer.PullFromnot work, cause it was not used totally.(context.Background()is actually used.) https://github.com/apache/rocketmq-client-go/blob/f4875c1bbca66be050ec71359a8b447e0b63e743/consumer/consumer.go#L896 - the returned error is inexplicit: https://github.com/apache/rocketmq-client-go/blob/f4875c1bbca66be050ec71359a8b447e0b63e743/internal/remote/future.go#L63-L65
Brief changelog
make ctx working, and returns the explicit error.
fix issue: https://github.com/apache/rocketmq-client-go/issues/1131#issue-2175839675