ratis icon indicating copy to clipboard operation
ratis copied to clipboard

RATIS-931. Fixed Add a raft group to all peers currently registered

Open juaby opened this issue 5 years ago • 2 comments

fixed In the log service, when creating a log, add a raft group to all group peers, where the group peers are not all peers currently registered

juaby avatar May 07 '20 02:05 juaby

You can open a jira at https://issues.apache.org/jira/projects/RATIS/issues, and add the jira number in the Pull Request title. Besides, the Pull Request title is also too long.

runzhiwang avatar May 07 '20 05:05 runzhiwang

Can we rename the member peers to be allKnownPeers or similar? Something to try to prevent such an error in the future.

What about a test? Did you try to write a unit test to catch this? I think having 4 available workers, create a log, and then look at the raft groups and see that it has 4 members instead of 3 would work.

Sorry, it took so long to reply to you. about the log service, it is okay to verify according to the document (because the number of worker nodes is equal to the number of new raft groups), but when more than 3 worker nodes are started, a log is created at the time, the metadata service will broadcast the addition of Raft groups to unnecessary nodes outside the new raft group. Personal suggestion: Ratis server adds verification. when an additional raft group is received, verify that the new raft group members must contain the current working node

juaby avatar Jun 10 '20 08:06 juaby