apache
Revert "Revert "RATIS-672. Vagrant test's Maven 404's""
This reverts commit 89abd139
What changes were proposed in this pull request?
./dev-support/vagrant/run_all_tests.sh build command was failing. There was previous patch available for the legacy issue , concerning Maven 404 response from apache mirror for maven installation. The fix has to do with reverting the patch to original fix, and merging the new changes with the concerned files.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-672
How was this patch tested?
$./dev-support/vagrant/run_all_tests.sh build , command ran successfully
The new Dockerfile would always require some arguments I guess. Can we give some default values to the ARG defined in the Dockerfile?
@lokeshj1703 Thanks for the feedback, I'll take a look into dockerfile build.
Found https://yetus.apache.org/documentation/0.12.0/RELEASENOTES/ YETUS-919 was specifically created to address the issue of build failure in YETUS for docker args resolution vis-a-vis ratis.
add_docker_build_arg should get the work done. In Dockerfile the argument for protobuf is already there, and it picks the value from source /dev-support/ci/common.sh but it seems in case of yetus it fails as the common.sh is not sufficient in getting executed.
I'll try to use the new mechanism of passing the args for docker build in yetus.