ranger icon indicating copy to clipboard operation
ranger copied to clipboard

RANGER-5112: Remove unused dependencies

Open kokosing opened this issue 1 year ago • 7 comments

Remove unused dependencies

kokosing avatar Jul 26 '24 16:07 kokosing

@mneethiraj I have found these using mvn maven-dependency-plugin:analyze. I see other unused dependencies, so I will be posting other PRs like that shortly.

Would you like to grant me some access so CI could be executed for my PRs so I could see if my changes are working?

kokosing avatar Jul 26 '24 16:07 kokosing

FYI @ksobolew

kokosing avatar Jul 26 '24 16:07 kokosing

I am not sure if it is the correct direction. I am not sure if I can trust mvn dependency:analyze here.

kokosing avatar Jul 29 '24 10:07 kokosing

@mneethiraj do you think this is something I should invest my time in?

kokosing avatar Aug 01 '24 08:08 kokosing

@kokosing - removal of unused dependencies will be of huge help; thank you for getting started on this. Can you please rebase this PR, so that I can trigger CI?

BTW, I recently started contributing to Trino; really liked Trino enforces several things during build time - like unused dependencies, duplicate classes, conflicting versions of dependencies, strict ordering of dependencies (in pom.xml). It will be awesome to get these in Ranger as well. Given your background in Trino, will you be able to help with these?

mneethiraj avatar Aug 01 '24 15:08 mneethiraj

I have rebased the PR.

The way how it is done in Trino is an effect of huge effort over many years by multiple people. I am afraid I might not be able to migrate the entire Ranger project. The way it is done is via usage of https://github.com/airlift/airbase. It is easy to start a new project that is based on that, with existing project huge effort. However the biggest challenge I have with it is how to maek sure that changes I would be doing are safe to merge. It is easy to have compilation passing, but get errors on runtime. @mneethiraj do you believe that Ranger have good enough test coverage in CI that we move forward with it?

kokosing avatar Aug 02 '24 14:08 kokosing

@kokosing

I've rebased the PR with master and run CI, please take a look - thanks!

kumaab avatar Jan 13 '25 01:01 kumaab