[Bug] Checkstyle check is not applied to all tests

[BewareMyPower]

Search before asking

• [X] I searched in the issues and found nothing similar.

Read release policy

• [X] I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

Version

master branch

Minimal reproduce step

Add a test pulsar-broker/src/test/java/org/apache/pulsar/SimpleTest.java

package org.apache.pulsar;

// 1. The import order is wrong
import org.testng.annotations.Test;
import org.testng.Assert;

public class SimpleTest {
    @Test // 2. The indents and number blanks are wrong
    public void test() {Assert.assertEquals(1 + 2, 3);}
}

Run

mvn initialize checkstyle:check -pl pulsar-broker

What did you expect to see?

The checkstyle:check should fail.

What did you see instead?

It succeeded.

Anything else?

No response

Are you willing to submit a PR?

• [ ] I'm willing to submit a PR!

[four1er]

I want to solve it, pls assign it to me, thx!

[555vedant]

@four1er you are still working on it ??

[yingh0ng]

This is due to the import check in suppress.xml that suppresses the test resource.

[iihimanshuu]

If the issue is open assign to me please

[iihimanshuu]

Can i join this issue?

[BewareMyPower]

I assigned it to you @frHimanshu

[Praveen7294]

If no one is currently working on this issue, I'm happy to work on it.

As expected, the errors can be seen below:

$ ./mvnw initialize checkstyle:check -pl pulsar-broker
MINGW support requires --add-opens java.base/java.lang=ALL-UNNAMED
MINGW support requires --add-opens java.base/java.lang=ALL-UNNAMED
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Detecting the operating system and CPU architecture
[INFO] ------------------------------------------------------------------------
[INFO] os.detected.name: windows
[INFO] os.detected.arch: x86_64
[INFO] os.detected.bitness: 64
[INFO] os.detected.version: 10.0
[INFO] os.detected.version.major: 10
[INFO] os.detected.version.minor: 0
[INFO] os.detected.classifier: windows-x86_64
[INFO]
[INFO] ------------------< org.apache.pulsar:pulsar-broker >-------------------
[INFO] Building Pulsar Broker 4.1.0-SNAPSHOT
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- enforcer:3.3.0:enforce (enforce-maven-version) @ pulsar-broker ---
[INFO] Rule 0: org.apache.maven.enforcer.rules.version.RequireMavenVersion passed
[INFO]
[INFO] --- enforcer:3.3.0:enforce (enforce-java-version) @ pulsar-broker ---
[INFO] Rule 0: org.apache.maven.enforcer.rules.version.RequireJavaVersion passed
[INFO]
[INFO] --- enforcer:3.3.0:enforce (enforce-maven) @ pulsar-broker ---
[INFO] Rule 0: org.apache.maven.enforcer.rules.version.RequireJavaVersion passed
[INFO] Rule 1: org.apache.maven.enforcer.rules.version.RequireMavenVersion passed
[INFO]
[INFO] --- directory:1.0:directory-of (directories) @ pulsar-broker ---
[INFO] Directory of org.apache.pulsar:pulsar set to: F:\GitHub\pulsar
[INFO]
[INFO] --- git-commit-id:4.9.10:revision (git-info) @ pulsar-broker ---
[INFO]
[INFO] --- properties:1.1.0:set-system-properties (default) @ pulsar-broker ---
[INFO] Set 2 system properties
[INFO]
[INFO] --- checkstyle:3.1.2:check (default-cli) @ pulsar-broker ---
[INFO] There are 436 errors reported by Checkstyle 10.14.2 with F:\GitHub\pulsar/buildtools/src/main/resources/pulsar/checkstyle.xml ruleset.
[ERROR] src\test\java\org\apache\bookkeeper\mledger\impl\MangedLedgerInterceptorImpl2Test.java:[22,1] (imports) ImportOrder: Import org.apache.pulsar.broker.intercept.ManagedLedgerInterceptorImplTest.TestPayloadProcessor appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\admin\AdminApiDelayedDeliveryTest.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Set'
[ERROR] src\test\java\org\apache\pulsar\broker\admin\AdminApiDelayedDeliveryTest.java:[33,1] (imports) ImportOrder: Import java.util.Set appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\admin\AdminApiDelayedDeliveryTest.java:[38,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert.*'
[ERROR] src\test\java\org\apache\pulsar\broker\admin\AdminApiDelayedDeliveryTest.java:[38,1] (imports) ImportOrder: Import org.testng.Assert.* appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\admin\AdminApiMultiBrokersTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'java.util.HashSet'
[ERROR] src\test\java\org\apache\pulsar\broker\admin\AdminApiMultiBrokersTest.java:[32,1] (imports) ImportOrder: Extra separation in import group before 'lombok.extern.slf4j.Slf4j'
[ERROR] src\test\java\org\apache\pulsar\broker\admin\AdminApiSubscriptionTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'java.util.HashMap'
[ERROR] src\test\java\org\apache\pulsar\broker\admin\AdminResourceTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'javax.ws.rs.core.Response.Status'
[ERROR] src\test\java\org\apache\pulsar\broker\admin\BookiesApiTest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Optional'
[ERROR] src\test\java\org\apache\pulsar\broker\admin\ClusterEndpointsAuthorizationTest.java:[46,1] (imports) ImportOrder: Import java.util.LinkedHashSet appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\admin\MockServletContext.java:[29,1] (imports) ImportOrder: Extra separation in import group before 'javax.servlet.Filter'
[ERROR] src\test\java\org\apache\pulsar\broker\admin\MockServletContext.java:[41,1] (imports) ImportOrder: Extra separation in import group before 'org.eclipse.jetty.util.AttributesMap'
[ERROR] src\test\java\org\apache\pulsar\broker\admin\NamespacesTest.java:[83,1] (imports) ImportOrder: Import org.apache.pulsar.broker.service.Topic appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\admin\TenantEndpointsAuthorizationTest.java:[42,1] (imports) ImportOrder: Import java.util.Set appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\admin\TopicPoliciesTest.java:[57,1] (imports) ImportOrder: Import org.apache.pulsar.broker.service.Topic appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\admin\TopicPoliciesWithBrokerRestartTest.java:[33,1] (imports) ImportOrder: Import java.nio.charset.StandardCharsets appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\admin\TopicsWithoutTlsTest.java:[42,1] (imports) ImportOrder: Import javax.ws.rs.container.AsyncResponse appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\admin\TopicsWithoutTlsTest.java:[45,1] (imports) ImportOrder: Import java.net.URI appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\admin\TopicsWithoutTlsTest.java:[49,1] (imports) ImportOrder: Import org.mockito.Mockito.doReturn appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\admin\v3\PackagesApiTest.java:[25,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\admin\v3\PackagesApiTest.java:[30,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.annotations.AfterMethod'
[ERROR] src\test\java\org\apache\pulsar\broker\admin\v3\PackagesApiTest.java:[34,1] (imports) ImportOrder: Extra separation in import group before 'java.io.File'
[ERROR] src\test\java\org\apache\pulsar\broker\admin\v3\PackagesApiTest.java:[34,1] (imports) ImportOrder: Import java.io.File appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\auth\MockAlwaysExpiredAuthenticationProvider.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'javax.naming.AuthenticationException'
[ERROR] src\test\java\org\apache\pulsar\broker\auth\MockAlwaysExpiredAuthenticationProvider.java:[24,1] (imports) ImportOrder: Import javax.naming.AuthenticationException appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\auth\MockAlwaysExpiredAuthenticationProvider.java:[26,1] (imports) ImportOrder: Import java.net.SocketAddress appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\auth\MockMultiStageAuthenticationProvider.java:[23,1] (imports) ImportOrder: Import java.net.SocketAddress appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\auth\MockMultiStageAuthenticationState.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'javax.naming.AuthenticationException'
[ERROR] src\test\java\org\apache\pulsar\broker\auth\MockMultiStageAuthenticationState.java:[26,1] (imports) ImportOrder: Import javax.naming.AuthenticationException appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\auth\MockMultiStageAuthenticationState.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'java.nio.charset.StandardCharsets.UTF_8'
[ERROR] src\test\java\org\apache\pulsar\broker\auth\MockMultiStageAuthenticationState.java:[28,1] (imports) ImportOrder: Import java.nio.charset.StandardCharsets.UTF_8 appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\auth\MockMutableAuthenticationProvider.java:[23,1] (imports) ImportOrder: Import javax.net.ssl.SSLSession appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\auth\MockMutableAuthenticationProvider.java:[24,1] (imports) ImportOrder: Import java.net.SocketAddress appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\auth\MockMutableAuthenticationState.java:[23,1] (imports) ImportOrder: Import java.util.concurrent.CompletableFuture appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\auth\SameThreadOrderedSafeExecutor.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.bookkeeper.common.util.OrderedExecutor'
[ERROR] src\test\java\org\apache\pulsar\broker\intercept\BrokerInterceptorUtilsTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'java.io.IOException'
[ERROR] src\test\java\org\apache\pulsar\broker\intercept\BrokerInterceptorUtilsTest.java:[28,1] (imports) ImportOrder: Import java.io.IOException appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\intercept\BrokerInterceptorUtilsTest.java:[31,1] (imports) ImportOrder: Extra separation in import group before 'org.mockito.ArgumentMatchers.eq'
[ERROR] src\test\java\org\apache\pulsar\broker\intercept\BrokerInterceptorUtilsTest.java:[31,1] (imports) ImportOrder: Import org.mockito.ArgumentMatchers.eq appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\intercept\ManagedLedgerInterceptorImplTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'io.netty.buffer.ByteBuf'
[ERROR] src\test\java\org\apache\pulsar\broker\intercept\MockBrokerInterceptor.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'javax.servlet.ServletException'
[ERROR] src\test\java\org\apache\pulsar\broker\intercept\MockBrokerInterceptor.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.PulsarService'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\AdvertisedListenersTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'java.net.URI'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\BrokerVersionFilterTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.ServiceConfiguration'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\BrokerVersionFilterTest.java:[27,1] (imports) ImportOrder: Import org.apache.pulsar.policies.data.loadbalancer.BrokerData appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\BrokerVersionFilterTest.java:[31,1] (imports) ImportOrder: Extra separation in import group before 'com.github.zafarkhaja.semver.Version'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\BrokerVersionFilterTest.java:[31,1] (imports) ImportOrder: Import com.github.zafarkhaja.semver.Version appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\channel\ServiceUnitStateDataTest.java:[26,1] (imports) ImportOrder: Import org.assertj.core.api.Assertions.assertThat appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\data\BrokerLoadDataTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.ServiceConfiguration'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\data\BrokerLookupDataTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'java.net.URI'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\filter\BrokerFilterTestBase.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'java.io.IOException'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\filter\BrokerFilterTestBase.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.ServiceConfiguration'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\filter\BrokerIsolationPoliciesFilterTest.java:[31,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Collections'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\filter\BrokerIsolationPoliciesFilterTest.java:[38,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.ServiceConfiguration'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\filter\BrokerLoadManagerClassFilterTest.java:[28,1] (imports) ImportOrder: Import java.util.HashMap appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\filter\BrokerMaxTopicCountFilterTest.java:[29,1] (imports) ImportOrder: Extra separation in import group before 'java.util.HashMap'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\filter\BrokerMaxTopicCountFilterTest.java:[29,1] (imports) ImportOrder: Import java.util.HashMap appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\filter\BrokerMaxTopicCountFilterTest.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert.assertEquals'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\filter\BrokerMaxTopicCountFilterTest.java:[33,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\filter\BrokerVersionFilterTest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'java.util.HashMap'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\manager\RedirectManagerTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.PulsarService'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\manager\RedirectManagerTest.java:[37,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Collections'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\manager\RedirectManagerTest.java:[37,1] (imports) ImportOrder: Import java.util.Collections appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\models\TopKBundlesTest.java:[22,1] (imports) ImportOrder: Import org.mockito.ArgumentMatchers.any appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\scheduler\SplitSchedulerTest.java:[43,1] (imports) ImportOrder: Import org.apache.pulsar.broker.loadbalance.extensions.models.SplitCounter appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\scheduler\UnloadSchedulerTest.java:[30,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Lists'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\scheduler\UnloadSchedulerTest.java:[46,1] (imports) ImportOrder: Import java.util.List appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\store\LoadDataStoreTest.java:[29,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Sets'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\extensions\store\LoadDataStoreTest.java:[44,1] (imports) ImportOrder: Import java.util.HashMap appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\impl\AvgShedderTest.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert.assertEquals'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\impl\AvgShedderTest.java:[33,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\impl\BrokerLoadManagerClassFilterTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.ServiceConfiguration'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\impl\BrokerLoadManagerClassFilterTest.java:[31,1] (imports) ImportOrder: Import java.util.HashSet appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\impl\BundleSplitterTaskTest.java:[38,1] (imports) ImportOrder: Extra separation in import group before 'java.util.HashMap'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\impl\BundleSplitterTaskTest.java:[38,1] (imports) ImportOrder: Import java.util.HashMap appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\impl\UniformLoadShedderTest.java:[27,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\LoadBalancerTestingUtils.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.BoundType'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\LoadBalancerTestingUtils.java:[26,1] (imports) ImportOrder: Import com.google.common.collect.BoundType appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\ModularLoadManagerStrategyTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'java.lang.reflect.Field'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\ModularLoadManagerStrategyTest.java:[28,1] (imports) ImportOrder: Import java.util.Collections appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\ModularLoadManagerStrategyTest.java:[34,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Set'
[ERROR] src\test\java\org\apache\pulsar\broker\loadbalance\ModularLoadManagerStrategyTest.java:[44,1] (imports) ImportOrder: Import org.apache.pulsar.policies.data.loadbalancer.BrokerData appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\lookup\http\v2\TopicLookupTest.java:[28,1] (imports) ImportOrder: Import java.util.concurrent.CompletableFuture appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\lookup\http\v2\TopicLookupTest.java:[29,1] (imports) ImportOrder: Import org.mockito.Mockito.spy appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\namespace\NamespaceCreateBundlesTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\broker\namespace\NamespaceCreateBundlesTest.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'java.util.UUID'
[ERROR] src\test\java\org\apache\pulsar\broker\namespace\NamespaceCreateBundlesTest.java:[27,1] (imports) ImportOrder: Import java.util.UUID appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\namespace\NamespaceCreateBundlesTest.java:[31,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.service.BrokerTestBase'
[ERROR] src\test\java\org\apache\pulsar\broker\namespace\NamespaceOwnershipListenerTests.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'java.util.List'
[ERROR] src\test\java\org\apache\pulsar\broker\namespace\NamespaceOwnershipListenerTests.java:[33,1] (imports) ImportOrder: Import java.util.List appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\namespace\NamespaceOwnershipListenerTests.java:[38,1] (imports) ImportOrder: Extra separation in import group before 'org.mockito.Mockito.doThrow'
[ERROR] src\test\java\org\apache\pulsar\broker\namespace\NamespaceOwnershipListenerTests.java:[38,1] (imports) ImportOrder: Import org.mockito.Mockito.doThrow appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\namespace\NamespaceUnloadingTest.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Sets'
[ERROR] src\test\java\org\apache\pulsar\broker\namespace\NamespaceUnloadingTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\broker\protocol\ProtocolHandlersTest.java:[30,1] (imports) ImportOrder: Extra separation in import group before 'io.netty.channel.ChannelInitializer'
[ERROR] src\test\java\org\apache\pulsar\broker\protocol\ProtocolHandlerUtilsTest.java:[30,1] (imports) ImportOrder: Extra separation in import group before 'java.io.IOException'
[ERROR] src\test\java\org\apache\pulsar\broker\protocol\ProtocolHandlerWithClassLoaderTest.java:[32,1] (imports) ImportOrder: Extra separation in import group before 'io.netty.channel.ChannelInitializer'
[ERROR] src\test\java\org\apache\pulsar\broker\protocol\SimpleProtocolHandlerTestsBase.java:[35,1] (imports) ImportOrder: Extra separation in import group before 'java.io.File'
[ERROR] src\test\java\org\apache\pulsar\broker\protocol\SimpleProtocolHandlerTestsBase.java:[35,1] (imports) ImportOrder: Import java.io.File appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\protocol\SimpleProtocolHandlerTestsBase.java:[49,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.common.util.PortManager.nextLockedFreePort'
[ERROR] src\test\java\org\apache\pulsar\broker\protocol\SimpleProtocolHandlerTestsBase.java:[49,1] (imports) ImportOrder: Import org.apache.pulsar.common.util.PortManager.nextLockedFreePort appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\resourcegroup\ResourceGroupServiceTest.java:[23,1] (imports) ImportOrder: Import org.apache.pulsar.broker.resourcegroup.ResourceGroup.PerMonitoringClassFields appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\resourcegroup\ResourceGroupServiceTest.java:[24,1] (imports) ImportOrder: Import org.apache.pulsar.broker.resourcegroup.ResourceGroup.BytesAndMessagesCount appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\resourcegroup\ResourceGroupServiceTest.java:[35,1] (imports) ImportOrder: Import org.testng.Assert appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\resourcegroup\ResourceGroupServiceTest.java:[37,1] (imports) ImportOrder: Import java.util.HashSet appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\resourcegroup\ResourceGroupUsageAggregationTest.java:[47,1] (imports) ImportOrder: Import java.util.Optional appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\resourcegroup\ResourceUsageTransportManagerTest.java:[34,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert.assertEquals'
[ERROR] src\test\java\org\apache\pulsar\broker\resourcegroup\ResourceUsageTransportManagerTest.java:[34,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\AdvertisedAddressTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'java.nio.charset.StandardCharsets'
[ERROR] src\test\java\org\apache\pulsar\broker\service\AdvertisedAddressTest.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.PulsarService'
[ERROR] src\test\java\org\apache\pulsar\broker\service\BacklogQuotaManagerConfigurationTest.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'org.mockito.Mockito.mock'
[ERROR] src\test\java\org\apache\pulsar\broker\service\BacklogQuotaManagerConfigurationTest.java:[27,1] (imports) ImportOrder: Import org.mockito.Mockito.mock appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\BkEnsemblesTestBase.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.PulsarService'
[ERROR] src\test\java\org\apache\pulsar\broker\service\BkEnsemblesTestBase.java:[36,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Sets'
[ERROR] src\test\java\org\apache\pulsar\broker\service\BkEnsemblesTestBase.java:[36,1] (imports) ImportOrder: Import com.google.common.collect.Sets appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\BkEnsemblesTestBase.java:[38,1] (imports) ImportOrder: Extra separation in import group before 'lombok.extern.slf4j.Slf4j'
[ERROR] src\test\java\org\apache\pulsar\broker\service\BrokerBkEnsemblesTests.java:[34,1] (imports) ImportOrder: Import com.google.common.collect.Sets appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\BrokerEntryMetadataE2ETest.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'java.time.Duration'
[ERROR] src\test\java\org\apache\pulsar\broker\service\BrokerInternalClientConfigurationOverrideTest.java:[35,1] (imports) ImportOrder: Import lombok.Cleanup appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\BrokerInternalClientConfigurationOverrideTest.java:[36,1] (imports) ImportOrder: Import java.util.Optional appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\BrokerServiceAutoTopicCreationTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'java.util.List'
[ERROR] src\test\java\org\apache\pulsar\broker\service\BrokerServiceBundlesCacheInvalidationTest.java:[25,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\BrokerTestBase.java:[31,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Sets'
[ERROR] src\test\java\org\apache\pulsar\broker\service\BrokerTestBase.java:[31,1] (imports) ImportOrder: Import com.google.common.collect.Sets appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\BrokerTestBase.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Random'
[ERROR] src\test\java\org\apache\pulsar\broker\service\BusyWaitServiceTest.java:[32,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert.assertEquals'
[ERROR] src\test\java\org\apache\pulsar\broker\service\BusyWaitServiceTest.java:[32,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\HashRangeAutoSplitStickyKeyConsumerSelectorTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'java.util.ArrayList'
[ERROR] src\test\java\org\apache\pulsar\broker\service\HashRangeAutoSplitStickyKeyConsumerSelectorTest.java:[25,1] (imports) ImportOrder: Import java.util.ArrayList appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\HashRangeAutoSplitStickyKeyConsumerSelectorTest.java:[32,1] (imports) ImportOrder: Extra separation in import group before 'org.mockito.Mockito.mock'
[ERROR] src\test\java\org\apache\pulsar\broker\service\HashRangeAutoSplitStickyKeyConsumerSelectorTest.java:[32,1] (imports) ImportOrder: Import org.mockito.Mockito.mock appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\KeyValueTest.java:[40,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert.assertEquals'
[ERROR] src\test\java\org\apache\pulsar\broker\service\KeyValueTest.java:[40,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\MessageCumulativeAckTest.java:[43,1] (imports) ImportOrder: Import org.apache.pulsar.broker.service.persistent.PersistentSubscription appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\MessageTTLTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'java.util.ArrayList'
[ERROR] src\test\java\org\apache\pulsar\broker\service\NonPersistentTopicE2ETest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Data'
[ERROR] src\test\java\org\apache\pulsar\broker\service\NonPersistentTopicE2ETest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.service.schema.SchemaRegistry'
[ERROR] src\test\java\org\apache\pulsar\broker\service\NonPersistentTopicE2ETest.java:[45,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\OneWayReplicatorTest.java:[89,1] (imports) ImportOrder: Import org.apache.pulsar.common.policies.data.AutoTopicCreationOverride appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\OneWayReplicatorTestBase.java:[27,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\OpportunisticStripingTest.java:[29,1] (imports) ImportOrder: Import org.testng.AssertJUnit.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\PartitionKeyTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.client.api.Message'
[ERROR] src\test\java\org\apache\pulsar\broker\service\persistent\ChecksumTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'java.util.List'
[ERROR] src\test\java\org\apache\pulsar\broker\service\persistent\ChecksumTest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.bookkeeper.mledger.Entry'
[ERROR] src\test\java\org\apache\pulsar\broker\service\persistent\ChecksumTest.java:[38,1] (imports) ImportOrder: Extra separation in import group before 'com.scurrilous.circe.checksum.Crc32cIntChecksum'
[ERROR] src\test\java\org\apache\pulsar\broker\service\persistent\ChecksumTest.java:[38,1] (imports) ImportOrder: Import com.scurrilous.circe.checksum.Crc32cIntChecksum appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\persistent\ChecksumTest.java:[40,1] (imports) ImportOrder: Extra separation in import group before 'io.netty.buffer.ByteBuf'
[ERROR] src\test\java\org\apache\pulsar\broker\service\persistent\MessageDuplicationTest.java:[62,1] (imports) ImportOrder: Import org.apache.pulsar.broker.qos.AsyncTokenBucket appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\persistent\PartitionKeywordCompatibilityTest.java:[36,1] (imports) ImportOrder: Import java.util.List appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\persistent\ReplicatedSubscriptionSnapshotCacheTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.bookkeeper.mledger.PositionFactory'
[ERROR] src\test\java\org\apache\pulsar\broker\service\persistent\TopicDuplicationTest.java:[30,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Optional'
[ERROR] src\test\java\org\apache\pulsar\broker\service\PersistentTopicInitializeDelayTest.java:[32,1] (imports) ImportOrder: Import java.io.IOException appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\PersistentTopicInitializeDelayTest.java:[39,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\plugin\EntryFilterProviderTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.common.nar.NarClassLoader'
[ERROR] src\test\java\org\apache\pulsar\broker\service\plugin\EntryFilterProviderTest.java:[28,1] (imports) ImportOrder: Import java.io.IOException appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\plugin\EntryFilterTest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'lombok.extern.slf4j.Slf4j'
[ERROR] src\test\java\org\apache\pulsar\broker\service\ReplicatorGlobalNSTest.java:[46,1] (imports) ImportOrder: Extra separation in import group before 'java.lang.reflect.Method'
[ERROR] src\test\java\org\apache\pulsar\broker\service\ReplicatorGlobalNSTest.java:[46,1] (imports) ImportOrder: Import java.lang.reflect.Method appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\ReplicatorTlsTest.java:[26,1] (imports) ImportOrder: Import org.apache.pulsar.client.impl.PulsarClientImpl appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\ReplicatorTopicPoliciesTest.java:[40,1] (imports) ImportOrder: Import org.apache.pulsar.common.policies.data.DelayedDeliveryPolicies appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\ResendRequestTest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'java.lang.reflect.Field'
[ERROR] src\test\java\org\apache\pulsar\broker\service\ResendRequestTest.java:[32,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.service.persistent.PersistentTopic'
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\BaseAvroSchemaCompatibilityTest.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Arrays'
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\BaseAvroSchemaCompatibilityTest.java:[27,1] (imports) ImportOrder: Import java.util.Arrays appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\BookkeeperSchemaStorageTest.java:[29,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorage.bkException'
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\BookkeeperSchemaStorageTest.java:[29,1] (imports) ImportOrder: Import org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorage.bkException appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\ClientGetSchemaTest.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'java.util.ArrayList'
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\ClientGetSchemaTest.java:[31,1] (imports) ImportOrder: Extra separation in import group before 'java.util.function.Supplier'
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\ClientGetSchemaTest.java:[34,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.client.api.Consumer'
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\ClientGetSchemaTest.java:[50,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Sets'
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\ClientGetSchemaTest.java:[50,1] (imports) ImportOrder: Import com.google.common.collect.Sets appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\JsonSchemaCompatibilityCheckTest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'java.io.IOException'
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\JsonSchemaCompatibilityCheckTest.java:[30,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Data'
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\JsonSchemaCompatibilityCheckTest.java:[32,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.client.api.Schema'
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\PartitionedTopicsSchemaTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Collections'
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\PartitionedTopicsSchemaTest.java:[29,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\ProtobufNativeSchemaCompatibilityCheckTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'com.google.protobuf.Descriptors.Descriptor'
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\ProtobufNativeSchemaCompatibilityCheckTest.java:[28,1] (imports) ImportOrder: Import com.google.protobuf.Descriptors.Descriptor appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\validator\SchemaDataValidatorTest.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'com.fasterxml.jackson.databind.ObjectMapper'
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\validator\SchemaRegistryServiceWithSchemaDataValidatorTest.java:[24,1] (imports) ImportOrder: Import org.mockito.Mockito.mock appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\validator\SchemaRegistryServiceWithSchemaDataValidatorTest.java:[32,1] (imports) ImportOrder: Extra separation in import group before 'java.util.concurrent.CompletableFuture'
[ERROR] src\test\java\org\apache\pulsar\broker\service\schema\validator\SchemaRegistryServiceWithSchemaDataValidatorTest.java:[34,1] (imports) ImportOrder: Import org.apache.pulsar.broker.service.schema.SchemaRegistry.SchemaAndMetadata appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\StandaloneTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.AssertJUnit.assertEquals'
[ERROR] src\test\java\org\apache\pulsar\broker\service\StandaloneTest.java:[24,1] (imports) ImportOrder: Import org.testng.AssertJUnit.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\TopicListServiceTest.java:[31,1] (imports) ImportOrder: Import org.mockito.ArgumentMatchers.eq appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\TopicListServiceTest.java:[39,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert'
[ERROR] src\test\java\org\apache\pulsar\broker\service\TopicListServiceTest.java:[42,1] (imports) ImportOrder: Import java.net.InetSocketAddress appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\TopicListWatcherTest.java:[24,1] (imports) ImportOrder: Import org.mockito.Mockito.mock appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\TopicListWatcherTest.java:[30,1] (imports) ImportOrder: Import java.util.Arrays appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\TopicPoliciesServiceDisableTest.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.common.naming.TopicName'
[ERROR] src\test\java\org\apache\pulsar\broker\service\TopicTerminationTest.java:[35,1] (imports) ImportOrder: Extra separation in import group before 'io.netty.util.HashedWheelTimer'
[ERROR] src\test\java\org\apache\pulsar\broker\service\TopicTerminationTest.java:[35,1] (imports) ImportOrder: Import io.netty.util.HashedWheelTimer appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\TransactionalReplicateSubscriptionTest.java:[41,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Collections'
[ERROR] src\test\java\org\apache\pulsar\broker\service\TransactionalReplicateSubscriptionTest.java:[41,1] (imports) ImportOrder: Import java.util.Collections appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\TransactionalReplicateSubscriptionTest.java:[46,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert.assertEquals'
[ERROR] src\test\java\org\apache\pulsar\broker\service\TransactionalReplicateSubscriptionTest.java:[46,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\TransactionMarkerDeleteTest.java:[36,1] (imports) ImportOrder: Import org.apache.bookkeeper.mledger.PositionFactory appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\TransactionMetadataStoreServiceTest.java:[32,1] (imports) ImportOrder: Import com.google.common.collect.Sets appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\utils\ClientChannelHelper.java:[34,1] (imports) ImportOrder: Import org.apache.pulsar.common.api.proto.CommandAck appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\utils\ClientChannelHelper.java:[52,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Queues'
[ERROR] src\test\java\org\apache\pulsar\broker\service\utils\ClientChannelHelper.java:[52,1] (imports) ImportOrder: Import com.google.common.collect.Queues appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\service\utils\ClientChannelHelper.java:[54,1] (imports) ImportOrder: Extra separation in import group before 'io.netty.buffer.ByteBuf'
[ERROR] src\test\java\org\apache\pulsar\broker\stats\BookieClientsStatsGeneratorTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Map'
[ERROR] src\test\java\org\apache\pulsar\broker\stats\BookieClientsStatsGeneratorTest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.bookkeeper.mledger.proto.PendingBookieOpsStats'
[ERROR] src\test\java\org\apache\pulsar\broker\stats\BookieClientsStatsGeneratorTest.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'io.netty.buffer.ByteBuf'
[ERROR] src\test\java\org\apache\pulsar\broker\stats\BookieClientsStatsGeneratorTest.java:[33,1] (imports) ImportOrder: Import io.netty.buffer.ByteBuf appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\stats\LedgerOffloaderMetricsTest.java:[25,1] (imports) ImportOrder: Import java.util.List appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\stats\ManagedCursorMetricsTest.java:[31,1] (imports) ImportOrder: Import org.apache.bookkeeper.mledger.ManagedCursorAttributes appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\systopic\NamespaceEventsSystemTopicServiceTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Sets'
[ERROR] src\test\java\org\apache\pulsar\broker\systopic\PartitionedSystemTopicTest.java:[41,1] (imports) ImportOrder: Import org.apache.pulsar.broker.service.Topic appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\testcontext\MockEntryFilterProvider.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'java.io.IOException'
[ERROR] src\test\java\org\apache\pulsar\broker\testcontext\MockEntryFilterProvider.java:[28,1] (imports) ImportOrder: Import java.io.IOException appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\testcontext\MockEntryFilterProvider.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'org.mockito.ArgumentMatchers.anyString'
[ERROR] src\test\java\org\apache\pulsar\broker\testcontext\MockEntryFilterProvider.java:[33,1] (imports) ImportOrder: Import org.mockito.ArgumentMatchers.anyString appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\TimeAverageBrokerDataTest.java:[23,1] (imports) ImportOrder: Import java.util.HashMap appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\TopicEventsListenerTest.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Queue'
[ERROR] src\test\java\org\apache\pulsar\broker\TopicEventsListenerTest.java:[47,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert.assertEquals'
[ERROR] src\test\java\org\apache\pulsar\broker\TopicEventsListenerTest.java:[47,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\AuthenticatedTransactionProducerConsumerTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'java.security.KeyPair'
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\AuthenticatedTransactionProducerConsumerTest.java:[41,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\InMemTransactionBufferReaderTest.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'io.netty.buffer.ByteBuf'
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\InMemTransactionBufferReaderTest.java:[37,1] (imports) ImportOrder: Import org.apache.pulsar.broker.transaction.buffer.impl.InMemTransactionBufferReader appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\TopicTransactionBufferTest.java:[26,1] (imports) ImportOrder: Import org.apache.pulsar.broker.stats.BrokerOpenTelemetryTestUtil.assertMetricLongSumValue appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\TopicTransactionBufferTest.java:[41,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.bookkeeper.mledger.ManagedLedger'
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\TopicTransactionBufferTest.java:[64,1] (imports) ImportOrder: Import org.apache.pulsar.client.api.PulsarClientException appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\TopicTransactionBufferTest.java:[70,1] (imports) ImportOrder: Import org.apache.pulsar.client.impl.MessageIdImpl appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\TransactionBufferHandlerImplTest.java:[27,1] (imports) ImportOrder: Import org.mockito.ArgumentMatchers.any appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\TransactionBufferHandlerImplTest.java:[43,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Optional'
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\TransactionBufferHandlerImplTest.java:[43,1] (imports) ImportOrder: Import java.util.Optional appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\TransactionBufferTest.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Lists'
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\TransactionBufferTest.java:[31,1] (imports) ImportOrder: Extra separation in import group before 'java.util.List'
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\TransactionBufferTest.java:[34,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.service.persistent.PersistentTopic'
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\TransactionBufferTest.java:[36,1] (imports) ImportOrder: Import org.apache.pulsar.broker.transaction.buffer.impl.InMemTransactionBufferProvider appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\TransactionEntryImplTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'io.netty.buffer.ByteBuf'
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\utils\TransactionBufferTestImpl.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'java.util.concurrent.CompletableFuture'
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\buffer\utils\TransactionBufferTestImpl.java:[26,1] (imports) ImportOrder: Import java.util.concurrent.CompletableFuture appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\recover\TransactionRecoverTrackerTest.java:[31,1] (imports) ImportOrder: Extra separation in import group before 'java.lang.reflect.Field'
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\recover\TransactionRecoverTrackerTest.java:[31,1] (imports) ImportOrder: Import java.lang.reflect.Field appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\recover\TransactionRecoverTrackerTest.java:[35,1] (imports) ImportOrder: Extra separation in import group before 'org.mockito.Mockito.mock'
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\recover\TransactionRecoverTrackerTest.java:[35,1] (imports) ImportOrder: Import org.mockito.Mockito.mock appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\transaction\TransactionTest.java:[96,1] (imports) ImportOrder: Import org.apache.pulsar.broker.service.Topic appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\zookeeper\ZKReconnectTest.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'java.util.concurrent.TimeUnit'
[ERROR] src\test\java\org\apache\pulsar\broker\zookeeper\ZKReconnectTest.java:[33,1] (imports) ImportOrder: Import java.util.concurrent.TimeUnit appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\broker\zookeeper\ZooKeeperSessionExpireRecoveryTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Sets'
[ERROR] src\test\java\org\apache\pulsar\broker\zookeeper\ZooKeeperSessionExpireRecoveryTest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest'
[ERROR] src\test\java\org\apache\pulsar\client\api\AuthenticatedProducerConsumerTest.java:[37,1] (imports) ImportOrder: Import io.jsonwebtoken.SignatureAlgorithm appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\BytesKeyTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert'
[ERROR] src\test\java\org\apache\pulsar\client\api\ConsumerAckListTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'java.util.ArrayList'
[ERROR] src\test\java\org\apache\pulsar\client\api\ConsumerAckListTest.java:[28,1] (imports) ImportOrder: Import java.util.ArrayList appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\ConsumerBatchReceiveTest.java:[31,1] (imports) ImportOrder: Import java.util.UUID appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\ConsumerCleanupTest.java:[30,1] (imports) ImportOrder: Extra separation in import group before 'java.util.UUID'
[ERROR] src\test\java\org\apache\pulsar\client\api\ConsumerCleanupTest.java:[30,1] (imports) ImportOrder: Import java.util.UUID appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\DeadLetterTopicTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'java.time.Duration'
[ERROR] src\test\java\org\apache\pulsar\client\api\ExposeMessageRedeliveryCountTest.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'java.util.ArrayList'
[ERROR] src\test\java\org\apache\pulsar\client\api\ExposeMessageRedeliveryCountTest.java:[27,1] (imports) ImportOrder: Import java.util.ArrayList appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\MemoryLimitTest.java:[31,1] (imports) ImportOrder: Extra separation in import group before 'java.time.Duration'
[ERROR] src\test\java\org\apache\pulsar\client\api\MemoryLimitTest.java:[31,1] (imports) ImportOrder: Import java.time.Duration appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\MemoryLimitTest.java:[34,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert.assertEquals'
[ERROR] src\test\java\org\apache\pulsar\client\api\MemoryLimitTest.java:[34,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\MockBrokerService.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'io.netty.bootstrap.ServerBootstrap'
[ERROR] src\test\java\org\apache\pulsar\client\api\MockBrokerService.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'java.io.IOException'
[ERROR] src\test\java\org\apache\pulsar\client\api\MockBrokerService.java:[38,1] (imports) ImportOrder: Extra separation in import group before 'javax.servlet.ServletException'
[ERROR] src\test\java\org\apache\pulsar\client\api\MockBrokerService.java:[42,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.client.api.MockBrokerServiceHooks.CommandAckHook'
[ERROR] src\test\java\org\apache\pulsar\client\api\MockBrokerServiceHooks.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.common.api.proto.CommandAck'
[ERROR] src\test\java\org\apache\pulsar\client\api\MultiTopicsConsumerTest.java:[27,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\MultiTopicsConsumerTest.java:[31,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Lists'
[ERROR] src\test\java\org\apache\pulsar\client\api\MutualAuthenticationTest.java:[47,1] (imports) ImportOrder: Extra separation in import group before 'java.nio.charset.StandardCharsets.UTF_8'
[ERROR] src\test\java\org\apache\pulsar\client\api\MutualAuthenticationTest.java:[47,1] (imports) ImportOrder: Import java.nio.charset.StandardCharsets.UTF_8 appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\PartitionCreationTest.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'java.util.concurrent.TimeUnit'
[ERROR] src\test\java\org\apache\pulsar\client\api\PartitionCreationTest.java:[33,1] (imports) ImportOrder: Import java.util.concurrent.TimeUnit appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\ProducerCleanupTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'java.util.UUID'
[ERROR] src\test\java\org\apache\pulsar\client\api\ProducerCleanupTest.java:[28,1] (imports) ImportOrder: Import java.util.UUID appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\ProducerQueueSizeTest.java:[26,1] (imports) ImportOrder: Import java.util.ArrayList appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\ProxyProtocolTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'java.util.HashMap'
[ERROR] src\test\java\org\apache\pulsar\client\api\ProxyProtocolTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.client.impl.auth.AuthenticationTls'
[ERROR] src\test\java\org\apache\pulsar\client\api\ProxyProtocolTest.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\client\api\ProxyProtocolTest.java:[33,1] (imports) ImportOrder: Import lombok.Cleanup appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\PulsarMultiListenersWithInternalListenerNameTest.java:[34,1] (imports) ImportOrder: Extra separation in import group before 'io.netty.channel.EventLoopGroup'
[ERROR] src\test\java\org\apache\pulsar\client\api\PulsarMultiListenersWithInternalListenerNameTest.java:[34,1] (imports) ImportOrder: Import io.netty.channel.EventLoopGroup appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\PulsarMultiListenersWithInternalListenerNameTest.java:[58,1] (imports) ImportOrder: Extra separation in import group before 'org.mockito.ArgumentMatchers.any'
[ERROR] src\test\java\org\apache\pulsar\client\api\PulsarMultiListenersWithInternalListenerNameTest.java:[58,1] (imports) ImportOrder: Import org.mockito.ArgumentMatchers.any appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\ServiceUrlProviderTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\client\api\ServiceUrlProviderTest.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.PulsarService'
[ERROR] src\test\java\org\apache\pulsar\client\api\TlsHostVerificationTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\client\api\TlsProducerConsumerBase.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'java.util.HashMap'
[ERROR] src\test\java\org\apache\pulsar\client\api\TlsProducerConsumerBase.java:[29,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.client.admin.PulsarAdmin'
[ERROR] src\test\java\org\apache\pulsar\client\api\TlsProducerConsumerBase.java:[34,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Sets'
[ERROR] src\test\java\org\apache\pulsar\client\api\TlsProducerConsumerBase.java:[34,1] (imports) ImportOrder: Import com.google.common.collect.Sets appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\TlsSniTest.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.client.impl.auth.AuthenticationTls'
[ERROR] src\test\java\org\apache\pulsar\client\api\TlsSniTest.java:[30,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\client\api\TlsSniTest.java:[30,1] (imports) ImportOrder: Import lombok.Cleanup appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\TokenAuthenticatedProducerConsumerTest.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Sets'
[ERROR] src\test\java\org\apache\pulsar\client\api\TokenExpirationProduceConsumerTest.java:[37,1] (imports) ImportOrder: Import java.nio.charset.StandardCharsets appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\UnloadSubscriptionTest.java:[22,1] (imports) ImportOrder: Import org.apache.pulsar.client.api.SubscriptionType.Key_Shared appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\UnloadSubscriptionTest.java:[23,1] (imports) ImportOrder: Import org.apache.pulsar.client.api.SubscriptionType.Failover appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\UnloadSubscriptionTest.java:[24,1] (imports) ImportOrder: Import org.apache.pulsar.client.api.SubscriptionType.Exclusive appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\api\v1\V1_ProducerConsumerBase.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'java.lang.reflect.Method'
[ERROR] src\test\java\org\apache\pulsar\client\api\v1\V1_ProducerConsumerBase.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest'
[ERROR] src\test\java\org\apache\pulsar\client\impl\BatchMessageIdImplSerializationTest.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'java.io.IOException'
[ERROR] src\test\java\org\apache\pulsar\client\impl\BatchMessageIdImplSerializationTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.annotations.Test'
[ERROR] src\test\java\org\apache\pulsar\client\impl\BatchMessageIndexAckDisableTest.java:[38,1] (imports) ImportOrder: Extra separation in import group before 'java.util.ArrayList'
[ERROR] src\test\java\org\apache\pulsar\client\impl\BatchMessageIndexAckDisableTest.java:[38,1] (imports) ImportOrder: Import java.util.ArrayList appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\ClientWithSocks5ProxyTest.java:[39,1] (imports) ImportOrder: Extra separation in import group before 'java.net.InetSocketAddress'
[ERROR] src\test\java\org\apache\pulsar\client\impl\ClientWithSocks5ProxyTest.java:[39,1] (imports) ImportOrder: Import java.net.InetSocketAddress appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\ClientWithSocks5ProxyTest.java:[44,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert.assertEquals'
[ERROR] src\test\java\org\apache\pulsar\client\impl\ClientWithSocks5ProxyTest.java:[44,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\CompactedOutBatchMessageTest.java:[29,1] (imports) ImportOrder: Import org.apache.pulsar.common.api.proto.MessageIdData appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\ConnectionHandlerTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'java.time.Duration'
[ERROR] src\test\java\org\apache\pulsar\client\impl\ConnectionPoolTest.java:[35,1] (imports) ImportOrder: Import io.netty.util.concurrent.Promise appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\ConsumerAckTest.java:[30,1] (imports) ImportOrder: Extra separation in import group before 'java.io.Closeable'
[ERROR] src\test\java\org\apache\pulsar\client\impl\ConsumerConfigurationTest.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest'
[ERROR] src\test\java\org\apache\pulsar\client\impl\ConsumerDedupPermitsUpdateTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'java.util.concurrent.TimeUnit'
[ERROR] src\test\java\org\apache\pulsar\client\impl\ConsumerDedupPermitsUpdateTest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\client\impl\ConsumerDedupPermitsUpdateTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.BrokerTestUtil'
[ERROR] src\test\java\org\apache\pulsar\client\impl\ConsumerUnsubscribeTest.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\client\impl\DispatchAccordingPermitsTests.java:[36,1] (imports) ImportOrder: Extra separation in import group before 'java.util.concurrent.TimeUnit'
[ERROR] src\test\java\org\apache\pulsar\client\impl\DispatchAccordingPermitsTests.java:[36,1] (imports) ImportOrder: Import java.util.concurrent.TimeUnit appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\HierarchyTopicAutoCreationTest.java:[24,1] (imports) ImportOrder: Import java.util.List appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\KeyStoreTlsProducerConsumerTestWithAuthTest.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'io.jsonwebtoken.SignatureAlgorithm'
[ERROR] src\test\java\org\apache\pulsar\client\impl\KeyStoreTlsProducerConsumerTestWithAuthTest.java:[33,1] (imports) ImportOrder: Import io.jsonwebtoken.SignatureAlgorithm appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\KeyStoreTlsProducerConsumerTestWithAuthTest.java:[60,1] (imports) ImportOrder: Extra separation in import group before 'javax.crypto.SecretKey'
[ERROR] src\test\java\org\apache\pulsar\client\impl\KeyStoreTlsProducerConsumerTestWithAuthTest.java:[60,1] (imports) ImportOrder: Import javax.crypto.SecretKey appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\MessageChecksumTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'java.lang.reflect.Method'
[ERROR] src\test\java\org\apache\pulsar\client\impl\PartialPartitionedProducerTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\client\impl\PartialPartitionedProducerTest.java:[26,1] (imports) ImportOrder: Import java.lang.reflect.Field appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\PatternTopicsConsumerImplTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Lists'
[ERROR] src\test\java\org\apache\pulsar\client\impl\PatternTopicsConsumerImplTest.java:[30,1] (imports) ImportOrder: Extra separation in import group before 'java.time.Duration'
[ERROR] src\test\java\org\apache\pulsar\client\impl\PatternTopicsConsumerImplTest.java:[40,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.BrokerTestUtil'
[ERROR] src\test\java\org\apache\pulsar\client\impl\PerMessageUnAcknowledgedRedeliveryTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'java.util.concurrent.TimeUnit'
[ERROR] src\test\java\org\apache\pulsar\client\impl\PerMessageUnAcknowledgedRedeliveryTest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.service.BrokerTestBase'
[ERROR] src\test\java\org\apache\pulsar\client\impl\ProducerCloseTest.java:[39,1] (imports) ImportOrder: Extra separation in import group before 'java.nio.charset.StandardCharsets'
[ERROR] src\test\java\org\apache\pulsar\client\impl\ProducerCloseTest.java:[39,1] (imports) ImportOrder: Import java.nio.charset.StandardCharsets appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\ProducerConsumerInternalTest.java:[23,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\ProducerConsumerInternalTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'java.util.concurrent.CompletableFuture'
[ERROR] src\test\java\org\apache\pulsar\client\impl\ProducerConsumerInternalTest.java:[29,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\client\impl\ProducerEmptySchemaCacheTest.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'java.util.concurrent.TimeUnit'
[ERROR] src\test\java\org\apache\pulsar\client\impl\ProducerEmptySchemaCacheTest.java:[33,1] (imports) ImportOrder: Import java.util.concurrent.TimeUnit appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\ProducerEmptySchemaCacheTest.java:[36,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert.assertEquals'
[ERROR] src\test\java\org\apache\pulsar\client\impl\ProducerEmptySchemaCacheTest.java:[36,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\ProducerSemaphoreTest.java:[43,1] (imports) ImportOrder: Extra separation in import group before 'java.nio.ByteBuffer'
[ERROR] src\test\java\org\apache\pulsar\client\impl\ProducerSemaphoreTest.java:[43,1] (imports) ImportOrder: Import java.nio.ByteBuffer appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\PulsarClientConfigurationOverrideTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Map'
[ERROR] src\test\java\org\apache\pulsar\client\impl\PulsarClientConfigurationOverrideTest.java:[28,1] (imports) ImportOrder: Import java.util.Map appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\RawMessageSerDeserTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'io.netty.buffer.ByteBuf'
[ERROR] src\test\java\org\apache\pulsar\client\impl\RawMessageSerDeserTest.java:[28,1] (imports) ImportOrder: Import io.netty.buffer.ByteBuf appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\RawReaderTest.java:[62,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.client.impl.RawReaderImpl.DEFAULT_RECEIVER_QUEUE_SIZE'
[ERROR] src\test\java\org\apache\pulsar\client\impl\RawReaderTest.java:[62,1] (imports) ImportOrder: Import org.apache.pulsar.client.impl.RawReaderImpl.DEFAULT_RECEIVER_QUEUE_SIZE appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\ReaderTest.java:[41,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\client\impl\RetryUtilTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'java.util.concurrent.CompletableFuture'
[ERROR] src\test\java\org\apache\pulsar\client\impl\RetryUtilTest.java:[28,1] (imports) ImportOrder: Import java.util.concurrent.CompletableFuture appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\RetryUtilTest.java:[34,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert.assertEquals'
[ERROR] src\test\java\org\apache\pulsar\client\impl\RetryUtilTest.java:[34,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\SchemaDeleteTest.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest'
[ERROR] src\test\java\org\apache\pulsar\client\impl\SchemaDeleteTest.java:[29,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.common.naming.TopicName'
[ERROR] src\test\java\org\apache\pulsar\client\impl\SchemaDeleteTest.java:[34,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.common.schema.SchemaInfo'
[ERROR] src\test\java\org\apache\pulsar\client\impl\TableViewTest.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Sets'
[ERROR] src\test\java\org\apache\pulsar\client\impl\TopicDoesNotExistsTest.java:[31,1] (imports) ImportOrder: Extra separation in import group before 'java.util.UUID'
[ERROR] src\test\java\org\apache\pulsar\client\impl\TopicDoesNotExistsTest.java:[31,1] (imports) ImportOrder: Import java.util.UUID appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\TopicsConsumerImplTest.java:[64,1] (imports) ImportOrder: Import java.util.ArrayList appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\TopicsConsumerImplTest.java:[68,1] (imports) ImportOrder: Import java.util.HashMap appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\TopicsConsumerImplTest.java:[86,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert.assertEquals'
[ERROR] src\test\java\org\apache\pulsar\client\impl\TopicsConsumerImplTest.java:[86,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\impl\UnAcknowledgedMessagesTimeoutTest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'java.util.HashSet'
[ERROR] src\test\java\org\apache\pulsar\client\impl\UnAcknowledgedMessagesTimeoutTest.java:[30,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.service.BrokerTestBase'
[ERROR] src\test\java\org\apache\pulsar\client\processor\CustomBatchPayloadProcessor.java:[25,1] (imports) ImportOrder: Import org.apache.pulsar.client.api.Message appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\processor\DefaultProcessorWithRefCnt.java:[24,1] (imports) ImportOrder: Import org.apache.pulsar.client.api.Message appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\client\processor\MessagePayloadProcessorTest.java:[27,1] (imports) ImportOrder: Import io.netty.buffer.ByteBuf appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\common\naming\FlowOrQpsEquallyDivideBundleSplitAlgorithmTest.java:[31,1] (imports) ImportOrder: Import java.nio.charset.StandardCharsets.UTF_8 appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\common\naming\FlowOrQpsEquallyDivideBundleSplitAlgorithmTest.java:[33,1] (imports) ImportOrder: Import org.mockito.Mockito.doReturn appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\common\naming\NamespaceBundleSplitAlgorithmTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.common.naming.NamespaceBundleSplitAlgorithm.*'
[ERROR] src\test\java\org\apache\pulsar\common\naming\NamespaceBundleSplitAlgorithmTest.java:[25,1] (imports) ImportOrder: Import org.apache.pulsar.common.naming.NamespaceBundleSplitAlgorithm.* appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\common\naming\ServiceConfigurationTest.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'java.beans.Introspector'
[ERROR] src\test\java\org\apache\pulsar\common\naming\SpecifiedPositionsBundleSplitAlgorithmTest.java:[25,1] (imports) ImportOrder: Import java.util.ArrayList appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\common\naming\SpecifiedPositionsBundleSplitAlgorithmTest.java:[28,1] (imports) ImportOrder: Import org.mockito.Mockito.doReturn appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\common\protocol\ProducerBatchSendTest.java:[25,1] (imports) ImportOrder: Import org.mockito.Mockito.spy appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\common\protocol\ProducerBatchSendTest.java:[38,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.client.api.Schema'
[ERROR] src\test\java\org\apache\pulsar\compaction\CompactionRetentionTest.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'com.fasterxml.jackson.databind.ObjectMapper'
[ERROR] src\test\java\org\apache\pulsar\compaction\CompactionRetentionTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Collections'
[ERROR] src\test\java\org\apache\pulsar\compaction\CompactorMXBeanImplTest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'java.util.concurrent.TimeUnit'
[ERROR] src\test\java\org\apache\pulsar\compaction\CompactorMXBeanImplTest.java:[26,1] (imports) ImportOrder: Import java.util.concurrent.TimeUnit appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\compaction\EventTimeOrderCompactorTest.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'io.opentelemetry.api.common.Attributes'
[ERROR] src\test\java\org\apache\pulsar\compaction\ServiceUnitStateCompactionTest.java:[24,1] (imports) ImportOrder: Import org.apache.pulsar.broker.loadbalance.extensions.channel.ServiceUnitState.Assigning appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\compaction\ServiceUnitStateCompactionTest.java:[66,1] (imports) ImportOrder: Import org.apache.pulsar.broker.loadbalance.extensions.channel.ServiceUnitStateData appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\compaction\ServiceUnitStateCompactionTest.java:[86,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert'
[ERROR] src\test\java\org\apache\pulsar\compaction\StrategicCompactionTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'java.util.ArrayList'
[ERROR] src\test\java\org\apache\pulsar\functions\worker\FileServer.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'com.sun.net.httpserver.Headers'
[ERROR] src\test\java\org\apache\pulsar\functions\worker\TestPulsarFunctionUtils.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'java.io.BufferedReader'
[ERROR] src\test\java\org\apache\pulsar\functions\worker\TestPulsarFunctionUtils.java:[25,1] (imports) ImportOrder: Import java.io.BufferedReader appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\functions\worker\TestPulsarFunctionUtils.java:[39,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.base.Preconditions.checkArgument'
[ERROR] src\test\java\org\apache\pulsar\functions\worker\TestPulsarFunctionUtils.java:[39,1] (imports) ImportOrder: Import com.google.common.base.Preconditions.checkArgument appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\io\PulsarBatchSourceE2ETest.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Map'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarBatchSourceE2ETest.java:[30,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.client.admin.PulsarAdminException'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarBatchSourceE2ETest.java:[38,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.functions.worker.TestPulsarFunctionUtils'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarBatchSourceE2ETest.java:[42,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Lists'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarBatchSourceE2ETest.java:[42,1] (imports) ImportOrder: Import com.google.common.collect.Lists appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\io\PulsarFunctionAdminTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Sets'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarFunctionAdminTest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'java.lang.reflect.Method'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarFunctionAdminTest.java:[35,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.PulsarService'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarFunctionE2ETest.java:[33,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Lists'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarFunctionE2ETest.java:[37,1] (imports) ImportOrder: Extra separation in import group before 'java.nio.ByteBuffer'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarFunctionE2ETest.java:[48,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarSinkE2ETest.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'java.nio.ByteBuffer'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarSinkE2ETest.java:[38,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.client.admin.PulsarAdminException'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarSinkE2ETest.java:[62,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Lists'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarSinkE2ETest.java:[62,1] (imports) ImportOrder: Import com.google.common.collect.Lists appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\io\PulsarSinkE2ETest.java:[66,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarSourceE2ETest.java:[27,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Map'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarSourceE2ETest.java:[30,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.client.admin.PulsarAdminException'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarSourceE2ETest.java:[39,1] (imports) ImportOrder: Extra separation in import group before 'com.google.common.collect.Lists'
[ERROR] src\test\java\org\apache\pulsar\io\PulsarSourceE2ETest.java:[39,1] (imports) ImportOrder: Import com.google.common.collect.Lists appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\io\SinkForTest.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.functions.api.Record'
[ERROR] src\test\java\org\apache\pulsar\PulsarStandaloneTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'java.io.File'
[ERROR] src\test\java\org\apache\pulsar\schema\compatibility\SchemaTypeCompatibilityCheckTest.java:[42,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Collections'
[ERROR] src\test\java\org\apache\pulsar\schema\compatibility\SchemaTypeCompatibilityCheckTest.java:[42,1] (imports) ImportOrder: Import java.util.Collections appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\schema\compatibility\SchemaTypeCompatibilityCheckTest.java:[47,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.Assert.assertEquals'
[ERROR] src\test\java\org\apache\pulsar\schema\compatibility\SchemaTypeCompatibilityCheckTest.java:[47,1] (imports) ImportOrder: Import org.testng.Assert.assertEquals appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\security\MockedPulsarStandalone.java:[24,1] (imports) ImportOrder: Import com.fasterxml.jackson.databind.ObjectMapper appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\security\tls\ec\TlsWithECCertificateFileTest.java:[29,1] (imports) ImportOrder: Import org.apache.pulsar.client.admin.PulsarAdmin appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\security\tls\ec\TlsWithECKeyStoreTest.java:[31,1] (imports) ImportOrder: Import org.apache.pulsar.client.admin.PulsarAdmin appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\stats\client\PulsarBrokerStatsClientTest.java:[31,1] (imports) ImportOrder: Extra separation in import group before 'lombok.Cleanup'
[ERROR] src\test\java\org\apache\pulsar\utils\auth\tokens\TokensCliUtilsTest.java:[24,1] (imports) ImportOrder: Extra separation in import group before 'io.jsonwebtoken.Claims'
[ERROR] src\test\java\org\apache\pulsar\utils\auth\tokens\TokensCliUtilsTest.java:[37,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.annotations.DataProvider'
[ERROR] src\test\java\org\apache\pulsar\utils\SimpleTextOutputStreamTest.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'java.nio.charset.StandardCharsets'
[ERROR] src\test\java\org\apache\pulsar\utils\SimpleTextOutputStreamTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.common.util.SimpleTextOutputStream'
[ERROR] src\test\java\org\apache\pulsar\utils\SimpleTextOutputStreamTest.java:[29,1] (imports) ImportOrder: Extra separation in import group before 'io.netty.buffer.ByteBuf'
[ERROR] src\test\java\org\apache\pulsar\utils\SimpleTextOutputStreamTest.java:[29,1] (imports) ImportOrder: Import io.netty.buffer.ByteBuf appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\utils\StatsOutputStreamTest.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'io.netty.buffer.ByteBuf'
[ERROR] src\test\java\org\apache\pulsar\utils\StatsOutputStreamTest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'java.nio.charset.StandardCharsets'
[ERROR] src\test\java\org\apache\pulsar\utils\StatsOutputStreamTest.java:[28,1] (imports) ImportOrder: Extra separation in import group before 'org.testng.annotations.BeforeMethod'
[ERROR] src\test\java\org\apache\pulsar\websocket\proxy\ClientSideEncryptionWssProducer.java:[22,1] (imports) ImportOrder: Import org.apache.pulsar.common.api.EncryptionContext.EncryptionKey appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\websocket\proxy\MockAuthenticationProvider.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'javax.naming.AuthenticationException'
[ERROR] src\test\java\org\apache\pulsar\websocket\proxy\MockAuthenticationProvider.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.pulsar.broker.ServiceConfiguration'
[ERROR] src\test\java\org\apache\pulsar\websocket\proxy\MockUnauthenticationProvider.java:[23,1] (imports) ImportOrder: Extra separation in import group before 'javax.naming.AuthenticationException'
[ERROR] src\test\java\org\apache\pulsar\websocket\proxy\MockUnauthenticationProvider.java:[23,1] (imports) ImportOrder: Import javax.naming.AuthenticationException appears after other imports that it should precede
[ERROR] src\test\java\org\apache\pulsar\zookeeper\LocalBookkeeperEnsembleTest.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.bookkeeper.conf.ServerConfiguration'
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  41.681 s
[INFO] Finished at: 2025-04-30T22:08:30+05:30
[INFO] ------------------------------------------------------------------------
[INFO] 0 goals, 0 executed
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (default-cli) on project pulsar-broker: You have 436 Checkstyle violations. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

I'll fix all the errors and then open a PR.

[BewareMyPower]

@Praveen7294 Thanks, I assigned it to you

[Praveen7294]

@BewareMyPower , Do we need to identify all checks or only specific ones? The error above shows only an ImportOrder violation.

[BewareMyPower]

It should be all checks, which should follow buildtools/src/main/resources/pulsar/checkstyle.xml

[Praveen7294]

It should be all checks, which should follow buildtools/src/main/resources/pulsar/checkstyle.xml

ok, i guess i taking time to fix all the errors.

[Praveen7294]

sorry, i have my final year exams, so i was not giving enough time to it, after exam i will request a pull request

[Bhargavkonidena]

Please assign this request to me

[Praveen7294]

@Bhargavkonidena i m already working on it.

[Bhargavkonidena]

@BewareMyPower I have raised PR which fixes all tests and also attached a log file when we run StyleCheck. Please review it.

[lhotari]

@lhotari thanks i am already working on it, there are 3000+ checkstyle rule violations in broker module only and i have my final year exam coming so i am not able to give so much time to it after my exam i will give my full potential to it.

@Praveen7294 no worries. there isn't a hurry in addressing this issue. It's possible that some semi-automated solution could help in dealing with it.

We'd like to avoid completely reformatting the source code since that causes a lot of maintenance issues in Pulsar due to the way how we maintain Pulsar. Some background in these threads:

• https://lists.apache.org/thread/j6qvt45rndnvjypcmqxsfmddqt41bxjv
• https://lists.apache.org/thread/ryyfv8o33yyw9hmo5gnxn71boocn3mzs

In summary, currently bug fixes are made to master and then cherry-picked to maintenance branches such as branch-4.0, branch-3.0 and branch-3.3 (we will drop branch-3.3 from maintenance very soon, officially it has already ended).

The problem that unnecessary structural changes cause is that cherry-picking a change will become hard due to merge conflicts, unless the maintenance branches contain the same structural changes.

This does lead to the idea that perhaps we should just go with a completely automated solution such as spotless and apply it at the same time for master and the maintenance branches, without doing any cherry-picking. An earlier argument has been that git blame would stop working, but there's now a feature since Git 2.23 to address that, blame.ignoreRevsFile:

• https://git-scm.com/docs/git-blame#Documentation/git-blame.txt-blameignoreRevsFile
• https://medium.com/@ramunarasinga/git-blame-ignore-revs-to-ignore-bulk-formatting-changes-f20ac23e6155

In Pulsar, we'd add a file .git-blame-ignore-revs and configure git to ignore formatting commits by adding the hash of the formatting commit to that file. Then we'd add instructions that this configuration should be activated by running git config blame.ignoreRevsFile .git-blame-ignore-revs in the checked out repository.

GitHub also supports this feature: Ignore commits in the blame view

@BewareMyPower WDYT about applying Spotless to the complete code base in the way described above? Perhaps we could perform it only for the broker tests to start with.

[BewareMyPower]

It's okay for me.

[Praveen7294]

Most of the Checkstyle violations are related to ImportOrder, No spaces between import statements, LineLength, whitespace issues, and some naming conventions for final fields and class names. After fixing these violations, will it cause any problems in other branches?

[BewareMyPower]

After fixing these violations, will it cause any problems in other branches?

No. But it makes cherry-picking hard. Because we need to cherry-pick commits from master branch to release branches (e.g. branch-4.0) but they have some differences.

[nodece]

spotless +1, LGTM

[lhotari]

Most of the Checkstyle violations are related to ImportOrder, No spaces between import statements, LineLength, whitespace issues, and some naming conventions for final fields and class names. After fixing these violations, will it cause any problems in other branches?

ImportOrder and styling can be easily addressed in IntelliJ. Cherry-picking to branch-4.0 is easy and it would be sufficient to address branch-3.0 for the maintenance branches.

some naming conventions for final fields and class names

We might just revisit the convention so that this isn't applied to test classes. There's not much value in enforcing such conventions in test classes.

[Praveen7294]

@lhotari please review my PR