pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[refactor][java-client] Reduce code duplication in GET requests in admin client

Open andrasbeni opened this issue 3 years ago • 1 comments

Motivation

This is a continuation of #16377 to reduce code repetition in the admin client.

Modifications

Move the functionality implemented in InvocationCallbacks to a common place. Hide creation of CompletableFuture to be consistent with other HTTP method implementations (e.g. asyncPutRequest).

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • [x] doc-not-needed This is pure refactoring, no behavior is changed.

andrasbeni avatar Aug 09 '22 15:08 andrasbeni

@andrasbeni Please provide a correct documentation label for your PR. Instructions see Pulsar Documentation Label Guide.

github-actions[bot] avatar Aug 09 '22 16:08 github-actions[bot]

/pulsarbot rerun-failure-checks

andrasbeni avatar Aug 12 '22 09:08 andrasbeni

/pulsarbot rerun-failure-checks

andrasbeni avatar Sep 01 '22 14:09 andrasbeni

/pulsarbot rerun-failure-checks

andrasbeni avatar Sep 06 '22 17:09 andrasbeni

/pulsarbot rerun-failure-checks

andrasbeni avatar Sep 10 '22 14:09 andrasbeni

/pulsarbot run-failure-checks

andrasbeni avatar Sep 12 '22 18:09 andrasbeni