pulsar-helm-chart icon indicating copy to clipboard operation
pulsar-helm-chart copied to clipboard
verified publisher icon apache

To address the function role vs clusterrole issue

Open bsheltonihs opened this issue 3 years ago • 1 comments

Fixes #230

Motivation

When functions are enabled it deploys only with clusterrole and clusterrolebinding. However the use case I have is I am unable to use those within a namespace.

Modifications

I followed the example in the already approved file "broker-cluster-role-binding.yaml" for the approach to deal with this issue. It allows for a role and rolebinding or clusterrole and clusterrolebinding and doesn't force you into only one.

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

bsheltonihs avatar Feb 21 '22 19:02 bsheltonihs

I believe that I have made the needed changes for it to be backwards compatible.

bsheltonihs avatar Feb 22 '22 15:02 bsheltonihs

Cool - shouldn't the Chart.yaml version be revved as well?

frankjkelly avatar Jul 12 '23 15:07 frankjkelly

Cool - shouldn't the Chart.yaml version be revved as well?

The releasing of the Helm chart has changed and will be handled in a more controlled way with Apache style release voting. /Cc @michaeljmarshall

lhotari avatar Jul 12 '23 17:07 lhotari