pulsar-helm-chart icon indicating copy to clipboard operation
pulsar-helm-chart copied to clipboard
verified publisher icon apache

Tiered Storage config

Open pellicano opened this issue 4 years ago • 13 comments

Fixes #72

Motivation

Comply with Tiered Storage configuration. https://pulsar.apache.org/docs/en/concepts-tiered-storage/ https://pulsar.apache.org/docs/en/cookbooks-tiered-storage/

Modifications

Add a modified Helm Chart version from https://github.com/kafkaesque-io/pulsar-helm-chart. Other reference Helm Chart: https://github.com/streamnative/charts

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

pellicano avatar Jan 18 '22 21:01 pellicano

Hey @michaeljmarshall! @lhotari & @cdbartholomew mentioned that we should ping you when we made this contribution :+1:

Let us know if there is anything missing or what we can do to move this forward!

ckdarby avatar Jan 18 '22 21:01 ckdarby

Thanks for the comments @michaeljmarshall! Let me know if there's anything else.

pellicano avatar Jan 19 '22 19:01 pellicano

@sijie @codelipenghui @eolivelli @addisonj This PR would be a valuable addition to Apache Pulsar Helm chart. Please review.

lhotari avatar Jan 20 '22 05:01 lhotari

@MarvinCai @tuteng can you review this change?

sijie avatar Jan 20 '22 06:01 sijie

Changes applied as suggested by @sijie. Thank you. Let me know if there are any other changes.

pellicano avatar Jan 20 '22 17:01 pellicano

Addressed security concern related to AWS and Azure credentials. Let me know if there's anything else.

pellicano avatar Jan 24 '22 14:01 pellicano

@sijie - PTAL

michaeljmarshall avatar Jan 26 '22 05:01 michaeljmarshall

@sijie if you may take a look, I appreciate. Thank you.

pellicano avatar Jan 27 '22 14:01 pellicano

Any news here, @michaeljmarshall? @sijie if you may please take a look. We appreciate. Thank you.

pellicano avatar Feb 08 '22 19:02 pellicano

@sijie Can you assign over to someone else to take a look?

ckdarby avatar Apr 08 '22 15:04 ckdarby

@pellicano @ckdarby - are you able to rebase and then take a look at the failing status checks? Once that happens, I think we can merge this. Thanks!

michaeljmarshall avatar Apr 11 '22 22:04 michaeljmarshall

If needed I can open a new PR with this rebased.

benlongo avatar May 10 '22 06:05 benlongo

@pellicano - looks like some of the tests failed with this error:

Error: template: pulsar/templates/broker-statefulset.yaml:260:50: executing "pulsar/templates/broker-statefulset.yaml" at <eq .Values.broker.storageOffload.driver "aws-s3">: error calling eq: incompatible types for comparison

I assume this fails because it's comparing an unset value to a string value.

michaeljmarshall avatar May 14 '22 05:05 michaeljmarshall