pinot
pinot copied to clipboard
Add support for Auth in controller requests in java query client
The PR adds the support for auth and https when using fromController of java client.
The PR also does refactor some interfaces while maintaining backwards compatibility
- The
JsonAsyncHttpPinotClientTransportFactoryis refactored to initiate all the configs such as headers, scheme etc. fromPropertiesobject itself. This is done so that end user doesn't have to create and pass a new transport object if they want to enable https or auth. - Support for passing controllerUrl directly instead of host and port so as to maintain similarity with other methods such as
fromZookeeper,fromBrokerListetc. - Support for timeouts in controller requests
Codecov Report
Merging #9230 (dc885ff) into master (2f19683) will decrease coverage by
43.64%. The diff coverage is39.07%.
:exclamation: Current head dc885ff differs from pull request most recent head 4247a1d. Consider uploading reports for the commit 4247a1d to get more accurate results
@@ Coverage Diff @@
## master #9230 +/- ##
=============================================
- Coverage 69.88% 26.23% -43.65%
+ Complexity 5008 44 -4964
=============================================
Files 1854 1845 -9
Lines 98871 98633 -238
Branches 15043 15011 -32
=============================================
- Hits 69094 25875 -43219
- Misses 24904 70194 +45290
+ Partials 4873 2564 -2309
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | 26.23% <39.07%> (+0.08%) |
:arrow_up: |
| integration2 | ? |
|
| unittests1 | ? |
|
| unittests2 | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...e/pinot/broker/broker/helix/BaseBrokerStarter.java | 74.64% <ø> (-5.17%) |
:arrow_down: |
| ...ot/broker/requesthandler/BrokerRequestHandler.java | 0.00% <0.00%> (ø) |
|
| ...main/java/org/apache/pinot/client/BrokerCache.java | 0.00% <0.00%> (ø) |
|
| ...pache/pinot/client/BrokerCacheUpdaterPeriodic.java | 0.00% <0.00%> (ø) |
|
| ...ava/org/apache/pinot/client/ConnectionFactory.java | 33.33% <0.00%> (-27.39%) |
:arrow_down: |
| ...he/pinot/client/ControllerBasedBrokerSelector.java | 0.00% <0.00%> (ø) |
|
| ...ata/manager/realtime/RealtimeTableDataManager.java | 42.52% <0.00%> (-25.84%) |
:arrow_down: |
| ...ava/org/apache/pinot/core/plan/FilterPlanNode.java | 48.87% <0.00%> (-33.58%) |
:arrow_down: |
| .../java/org/apache/pinot/query/QueryEnvironment.java | 0.00% <0.00%> (-87.50%) |
:arrow_down: |
| ...ry/rules/PinotLogicalSortFetchEliminationRule.java | 0.00% <0.00%> (ø) |
|
| ... and 1373 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more