pinot icon indicating copy to clipboard operation
pinot copied to clipboard

non-compliant download page: links should use closer.lua script

Open pjfanning opened this issue 2 years ago • 3 comments

https://infra.apache.org/release-download-pages.html#download-scripts

See https://spark.apache.org/downloads.html as an example.

Its download links to https://www.apache.org/dyn/closer.lua/spark/spark-3.5.0/spark-3.5.0-bin-hadoop3.tgz (as an example).

INFRA team do not want us to link to https://archives.apache.org or https://downloads.apache.org directly. This is ok for the asc and sha sum files but the main file should have a clink like the spark one above. You don't need to change it for archived releases - the lua script will work that out.

pjfanning avatar Feb 19 '24 09:02 pjfanning

Thanks for raising this. Do you want to help fix this?

Jackie-Jiang avatar Apr 01 '24 20:04 Jackie-Jiang

@Jackie-Jiang I am not a Pinot contributor and don't know where your web site code is kept. Should I bring this up with Pinot dev list? For me, ASF project PMC members should be looking to comply with ASF rules. The ASF doesn't overburden you with rules - but the download links is a rule that you are expected to follow.

pjfanning avatar Apr 01 '24 20:04 pjfanning

@kelseiv Can you please take a look at this?

Jackie-Jiang avatar Apr 05 '24 00:04 Jackie-Jiang

This is for me. I'll get you a PR early in the week.

tlberglund avatar Apr 13 '24 23:04 tlberglund

@pjfanning Somewhat relatedly, we're seeing a problem with YouTube embeds not working. We're working around it on the Pinot site right now, but you can see an example of the same problem on the Kafka site. Where's the right channel to chase this down?

tlberglund avatar Apr 13 '24 23:04 tlberglund

@pjfanning Somewhat relatedly, we're seeing a problem with YouTube embeds not working. We're working around it on the Pinot site right now, but you can see an example of the same problem on the Kafka site. Where's the right channel to chase this down?

The Infrastructure team has added Content Security Policy headers to ASF websites.

pjfanning avatar Apr 13 '24 23:04 pjfanning

Is there a procedure by which we might ask to enable YouTube embeds?

tlberglund avatar Apr 14 '24 00:04 tlberglund

Is there a procedure by which we might ask to enable YouTube embeds?

You should be able to deploy a .htaccess file or something similar that overrides the CSP header. Raise an INFRA issue if you need assistance.

pjfanning avatar Apr 14 '24 06:04 pjfanning

Fixed here: https://github.com/apache/pinot-site/pull/113

xiangfu0 avatar Apr 14 '24 15:04 xiangfu0