ozone icon indicating copy to clipboard operation
ozone copied to clipboard

HDDS-9622. Disk Usage Legend Labels are large then UI is breaking

Open devabhishekpal opened this issue 2 years ago • 6 comments

What changes were proposed in this pull request?

HDDS-9622. Added responsive functionality for Disk Usage chart

Please describe your PR in detail:

  • Currently we have a Disk Usage page in Ozone Recon, which displays the space occupied by various keys, buckets and volumes.
  • However when we these entity names are very large, the label overlaps the Pie Chart that is rendered as a part of the UI to show the usage.
  • This change will introduce a more responsive approach to displaying the labels, where we change the layout based on the window size (height and width).
  • If we are having a large display size, we should be able to display the information beside the chart, else we should break the labels down to the next row.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9622

How was this patch tested?

This was a UI related patch and was tested manually.

  • When we have small-medium label lengths: Screenshot 2023-12-19 at 17 52 03 Screenshot 2023-12-19 at 17 52 44

  • When we are having larger label lengths:

https://github.com/apache/ozone/assets/43001336/c5d6c74a-3661-43cc-9912-f86a70490868

devabhishekpal avatar Dec 19 '23 12:12 devabhishekpal

Hello @ivandika3 @smitajoshi12 could you please review this PR? Any other inputs would also be appreciated.

devabhishekpal avatar Dec 19 '23 12:12 devabhishekpal

@devabhishekpal PR Title should match to JIRA title. Can you try with Buckets and other objects and keys.

smitajoshi12 avatar Dec 19 '23 12:12 smitajoshi12

@smitajoshi12 Thanks for the suggestions. I changed the PR title, and also updated the screen recording with the behaviour on long label lengths for volumes, buckets and keys in various widths.

devabhishekpal avatar Dec 24 '23 05:12 devabhishekpal

@ivandika3 @devmadhuu @dombizita Could you also PTAL and let me know of any other suggestions? Thanks a lot

devabhishekpal avatar Dec 24 '23 05:12 devabhishekpal

@devabhishekpal LGTM +1.

ivandika3 avatar Jan 12 '24 10:01 ivandika3

@dombizita , do you think this one is ready to merge?

ChenSammi avatar Mar 29 '24 09:03 ChenSammi

This has been addressed with the recent migration to ECharts and limiting the entities to the top 30 records. Please refer to the related JIRA for more information.

devabhishekpal avatar Jul 19 '24 06:07 devabhishekpal